-
Notifications
You must be signed in to change notification settings - Fork 4
Improve the Unix launcher script to handle Java versions > 1.8 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Improve the launcher script so that it can handle java verion strings of the form "1.8.0_xxx" as well as "11.0.x"
|
The version detection looks great, but is Java 8 actually required? |
TBH I do not know. I just thought 1.8 is a good baseline |
|
I can change the PR to require at least 1.5 as it did before |
5f968d2 to
b104235
Compare
b104235 to
200e784
Compare
|
I asked because some code still requires Java 6 to actually run correctly. And I'm not sure you can run it with Java 6 if you haven't compiled it with Java 6. Changing the PR to require at least 1.5 for now, as it did before, sounds good. |
|
Hm, |
|
I changed that back to 1.8, but I see now that I have not pushed those changes yet. |
|
see #13 |
|
Yeah, ICU4J 72 requires Java 8, so I don't see why we require Java 11? |
|
Other than the pending decision on minimal Java version, the version detection changes look good to me 👍 |
|
So I'm a bit confused. Should I require Java 1.5 (as it did before) or Java 8? If you merge #13 then the build target will be 1.8 |
|
Well, there are two conflicting issues:
and I guess the latter wins. |
|
So if we go for Java 8 this PR can go in as is |
Improve the launcher script so that it can handle java verion strings of the form "1.8.0_xxx" as well as "11.0.x"