Skip to content

Conversation

@egli
Copy link
Member

@egli egli commented Oct 1, 2025

Improve the launcher script so that it can handle java verion strings of the form "1.8.0_xxx" as well as "11.0.x"

Improve the launcher script so that it can handle java verion strings
of the form "1.8.0_xxx" as well as "11.0.x"
@egli egli requested a review from bertfrees October 1, 2025 14:29
@bertfrees
Copy link
Member

The version detection looks great, but is Java 8 actually required?

@egli
Copy link
Member Author

egli commented Oct 6, 2025

The version detection looks great, but is Java 8 actually required?

TBH I do not know. I just thought 1.8 is a good baseline

@egli
Copy link
Member Author

egli commented Oct 6, 2025

I can change the PR to require at least 1.5 as it did before

@egli egli force-pushed the feature/start_script_with_modern_java branch from 5f968d2 to b104235 Compare October 6, 2025 12:17
@egli egli force-pushed the feature/start_script_with_modern_java branch from b104235 to 200e784 Compare October 6, 2025 12:21
@bertfrees
Copy link
Member

I asked because some code still requires Java 6 to actually run correctly. And I'm not sure you can run it with Java 6 if you haven't compiled it with Java 6.

Changing the PR to require at least 1.5 for now, as it did before, sounds good.

@bertfrees bertfrees requested a review from rdeltour October 6, 2025 14:30
@egli
Copy link
Member Author

egli commented Oct 6, 2025

Hm, build-core.xml defines in the compile target a source and a target of 11. This was changed in b65054a from 1.8 to 11. Doesn't that mean that need at least Java11 to run Pipeline1?

@bertfrees
Copy link
Member

I changed that back to 1.8, but I see now that I have not pushed those changes yet.

@bertfrees
Copy link
Member

see #13

@rdeltour
Copy link
Member

rdeltour commented Oct 7, 2025

Yeah, ICU4J 72 requires Java 8, so I don't see why we require Java 11?

@rdeltour
Copy link
Member

rdeltour commented Oct 7, 2025

Other than the pending decision on minimal Java version, the version detection changes look good to me 👍

@egli
Copy link
Member Author

egli commented Oct 8, 2025

So I'm a bit confused. Should I require Java 1.5 (as it did before) or Java 8? If you merge #13 then the build target will be 1.8

@bertfrees
Copy link
Member

Well, there are two conflicting issues:

  • some code does not work with Java > 6
  • but apparently ICU4J 72 requires Java 8.

and I guess the latter wins.

@egli
Copy link
Member Author

egli commented Oct 9, 2025

So if we go for Java 8 this PR can go in as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants