Improving variable names in the entire lesson #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #484, closes #302
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Based on #484, and specifically this comment, changes were made in all .Rmd files inside the episodes/ directory to improve variable names following best practices: not using dots, use snake_case, and overall making them consistent across episodes.
To make sure I didn't break any part of the lesson, I compared side-by-side the current rendered lesson and my local rendered version with the name changes and made sure that everything was ok. It was relatively simple, as the Rmd integration let me know if there was an error in a code chunk or graph. And I made sure all the outputs of the code chunks (including plots) were being generated correctly in the rendered version of my changes.
The idea is that this PR is merged when the lesson is not being actively taught, which to our knowledge will be on Sept 2.
I preview of how the changes look like is here https://carpentry.library.ucsb.edu/r-raster-vector-geospatial/, if you'd like to also compare side-by-side
Here is a complete list of the 84 variable names that were changed, written in the format old_variable_name -> new_variable_name: