Skip to content

Conversation

@v-tarasevich-blitz-brain
Copy link
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Dec 3, 2025

https://linear.app/acryl-data/issue/CAT-962/implement-step-2-createedit-ingestion-source-details-page-except

This PR adds Ingestion Source Details Form to the second step of new create/update source flow

Screencast.From.2025-12-05.15-45-55.mp4
image

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 3, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--cat-962--ingestion-source-step2 branch from 01d33b1 to 5867772 Compare December 3, 2025 19:04
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Dec 3, 2025

✅ Meticulous spotted 0 visual differences across 987 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 95cb9af. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 88.08290% with 23 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ection/recipeForm/fields/SecretField/useSecrets.ts 16.66% 15 Missing ⚠️
...app/ingestV2/source/builder/useIngestionSources.ts 42.85% 4 Missing ⚠️
datahub-web-react/src/app/ingestV2/source/utils.ts 25.00% 3 Missing ⚠️
...eact/src/app/sharedV2/forms/multiStepForm/types.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title [WIP] feat(ingestion): add the new details form (step 2) feat(ingestion): add the new details form (step 2) Dec 5, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain marked this pull request as ready for review December 5, 2025 13:24
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Bundle Report

Changes will increase total bundle size by 25.25kB (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.79MB 25.25kB (0.09%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 25.25kB 19.17MB 0.13%

Files in assets/index-*.js:

  • ./src/app/ingestV2/source/builder/RecipeForm/common.tsx → Total Size: 15.54kB

  • ./src/app/ingestV2/source/builder/RecipeForm/csv.ts → Total Size: 1.44kB

  • ./src/alchemy-components/components/Breadcrumb/components.ts → Total Size: 595 bytes

  • ./src/alchemy-components/components/Button/utils.ts → Total Size: 7.36kB

  • ./src/app/ingestV2/runDetails/IngestionRunDetailsPage.tsx → Total Size: 1.59kB

  • ./src/app/ingestV2/source/builder/RecipeForm/bigqueryBeta.ts → Total Size: 2.38kB

  • ./src/app/ingestV2/source/builder/RecipeForm/constants.ts → Total Size: 9.82kB

  • ./src/alchemy-components/components/Tabs/Tabs.tsx → Total Size: 6.91kB

  • ./src/app/ingestV2/source/builder/RecipeForm/TestConnection/TestConnectionButton.tsx → Total Size: 4.97kB

  • ./src/app/ingestV2/source/builder/RecipeForm/bigquery.ts → Total Size: 1.68kB

  • ./src/app/ingestV2/source/builder/RecipeForm/kafka.ts → Total Size: 5.05kB

  • ./src/alchemy-components/components/Input/Input.tsx → Total Size: 3.5kB

  • ./src/app/entityV2/shared/EntitySearchSelect/EntitySearchDropdown.tsx → Total Size: 5.03kB

  • ./src/app/ingestV2/shared/hooks/useCapabilitySummary.ts → Total Size: 2.66kB

  • ./src/app/ingestV2/source/builder/RecipeForm/azure.ts → Total Size: 5.97kB

  • ./src/app/ingestV2/source/builder/RecipeForm/looker.ts → Total Size: 3.47kB

  • ./src/app/ingestV2/source/builder/RecipeForm/dbt_cloud.tsx → Total Size: 10.62kB

  • ./src/app/ingestV2/source/builder/RecipeForm/hive.ts → Total Size: 1.33kB

  • ./src/alchemy-components/components/Icon/Icon.tsx → Total Size: 1.68kB

  • ./src/app/ingestV2/source/builder/IngestionSourceBuilderModal.tsx → Total Size: 4.69kB

  • ./src/alchemy-components/components/TextArea/TextArea.tsx → Total Size: 2.06kB

  • ./src/app/ingestV2/source/builder/NameSourceStep.tsx → Total Size: 11.78kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants