-
Notifications
You must be signed in to change notification settings - Fork 92
Add get_model_lineage_dev CLI tool
#420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a48b7a2 to
76ac932
Compare
|
Thanks Vince! I am wondering if we should not create new tools instead of making Here are my Pros/Cons of having new tools for
So, I am in the camp of adding this functionality but in new tools ; and I'd be keen to hear other people's opinions about it. As a side note, would you be able to set up signed commits for this repo? We can bypass this check at the PR level as repo admins, but this repo expects all commits to be signed now. |
|
@b-per Crap, that's how I originally had it (shouldn't have squashed 😢 ) I didn't like it because when I was trying it out, exactly like you pointed to, it seemed to arbitrarily pick which tool it used. So I could run very similar queries and it would give two different results. We could give better names/descriptions so the tool wouldn't get confused but I don't think the user would necessarily know if they were getting the answer they expected.
I think it would just run the tool and the user would see it asking to run If it were to be two separate tools, would you think it should be a cli tool or a discovery tool. My entire thought process was "Discovery is NOT just platform", especially after listening to Jason's talk at Coalesce where he talked about them abstractly. This very much relates to #418 in my head. Rebased with gpgSign on, no idea why it was set to false for this repo. Also on this
|
76ac932 to
c70b52e
Compare
|
Hey @VDFaller and @b-per, I'm sorry for the back-and-forth on this. I told Vince that I was appreciative of sticking with the existing I like the router approach because the agent typically doesn't care whether the information is coming from a local or remote source; the user cares more about that. Also, with the latest config changes, it is quite easy to point the agent to local or remote. If Furthermore, this router approach can be applied to the Semantic Layer tools in the future. It is a source of frustration for some users that these tools don't work locally. |
Add a fallback path for Discovery tools to get use CLI functionality Add ModelLineage type with main constructor `from_manifest` The CLI path will not work until auto-disable is functioning correctly.
c70b52e to
adf92cc
Compare
add endpoint args to the tool.
08b5157 to
c041c1a
Compare
get_model_lineage_dev CLI tool
Summary
Added a tool for parsing the manifest to get the lineage.
What Changed
Just parses then reads the manifest.
Why
So that it's usable by non-cloud customers.
Checklist
Additional Notes
There are some differences in the outputs. I can try to line them up if needed.
Prompt Call & Response
jqon the manifest