Repository navigation
refactor: Implement simplified path handling system - #3
Merged
Merged
Conversation
Major path handling refactor to address cross-platform issues: **Key Changes:** - Replace complex PathValidator with SimpleFileChecker - TRUE HANDS-OFF approach: accept all paths as-is from clients - Container mode: simple /workspace/ prefix only - Pass original paths to debug adapter unchanged - Remove cross-platform path interpretation logic **New Components:** - src/utils/simple-file-checker.ts - minimal file existence checking - Updated server.ts to use SimpleFileChecker for immediate UX feedback - Enhanced documentation and architecture guides **Removed Components:** - src/utils/path-validator.ts - overly complex cross-platform logic - Associated documentation for deprecated path resolution **Benefits:** - Eliminates unsolvable cross-platform edge cases - Lets OS and debug adapter handle path resolution natively - Cleaner, more maintainable codebase - Better separation of concerns This addresses Linux CI failures while maintaining Windows compatibility. Still investigating container test path resolution for 'host-examples' paths. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ittent failures - Simplified cross-platform path handling in session manager and file checker - Added container-path-utils for better path normalization and validation - Fixed intermittent SSE test failures on Windows caused by port reuse race condition - Added 200ms delay after port release in findAvailablePort() to ensure Windows fully releases ports - Implemented retry logic (up to 3 attempts) in startSSEServer() when encountering EACCES errors - Enhanced cleanup with graceful shutdown (SIGTERM first, then SIGKILL if needed) - Updated error scenarios tests for improved path handling - Added comprehensive documentation of the SSE test fix The SSE test was failing with 'EACCES: permission denied' when running multiple times in a loop on Windows. This was due to a race condition where the OS hadn't fully released the port between the availability check and actual server startup. These changes significantly improve CI/CD pipeline stability, especially on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major path handling refactor to address cross-platform issues:
Key Changes:
New Components:
Removed Components:
Benefits:
This addresses Linux CI failures while maintaining Windows compatibility. Still investigating container test path resolution for 'host-examples' paths.
🤖 Generated with Claude Code
📋 Description
Please include a summary of the changes and which issue is fixed. Include relevant motivation and context.
Fixes # (issue number)
🔄 Type of Change
Please delete options that are not relevant.
✅ Checklist
🧪 Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Test Configuration:
📸 Screenshots (if applicable)
If your changes include UI updates or visual debugging improvements, please add screenshots.
🔗 Related Issues
Link any related issues here:
📝 Additional Notes
Any additional information that reviewers should know.
Reviewer: @debugmcp