Repository navigation
test(go): leave the noDebug fixture's temp dir to the OS when rmdir stays EBUSY (#866) - #873
Merged
Merged
Conversation
…tays EBUSY (#866) The "reports the exit code under noDebug" case removed its temp directory in a finally with rmSync's 10 x 200 ms retry, and on windows-latest that was twice not enough (run 37406647101 for PR #862, run 37653235241 for PR #868): Delve holds the exited debuggee's image until its own exit, which the session's close does not wait for, and the EBUSY failed a test whose debugging part had passed — taking the Windows job with it. A cleanup EBUSY/EPERM is now logged and the directory left under the temp dir for the OS, the way mcp-server-self-debug.test.ts already treats its inner dir; any other error still throws. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/adapters/go/integration/go-exit-code.test.ts› "reports the exit code under noDebug" removed its temp directory in afinallywithrmSync's 10 × 200 ms retry. Onwindows-latestthat was twice not enough — run 37406647101 (PR #862) and, today, run 37653235241 (PR #868): Delve holds the exited debuggee's image until its own exit, which the session's close does not wait for, and theEBUSYfailed a test whose debugging part had passed, taking the whole Windows job with it (#866, option 1).How
The cleanup keeps the retry; an
EBUSY/EPERMthat survives it is logged ([go-exit-code] leaving <dir> to the OS: rmdir hit EBUSY (issue #866)) and the directory is left under the temp dir for the OS, the waytests/e2e/mcp-server-self-debug.test.tsalready treats its inner dir. Any other error still throws. Test-only change.Verified
Windows 11, Go + Delve on PATH:
npx vitest run tests/adapters/go/integration/go-exit-code.test.ts→ 3 passed (the noDebug case in 7.1 s).npm run typecheck:testsclean.Fixes #866
🤖 Generated with Claude Code