Skip to content

test(go): leave the noDebug fixture's temp dir to the OS when rmdir stays EBUSY (#866) #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debugmcpdev merged 2 commits into from
Oct 7, 2026
Merged

test(go): leave the noDebug fixture's temp dir to the OS when rmdir stays EBUSY (#866) #873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352bf53
test(go): leave the noDebug fixture's temp dir to the OS when rmdir s…
cynarlab Oct 7, 2026
2a5b021
Merge main into fix/866-go-exit-code-cleanup-ebusy
debugmcpdev Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/adapters/go/integration/go-exit-code.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,18 @@ describe.skipIf(!hasGo)('Go exit code from Delve\'s console status line (issue #
} finally {
// On Windows the exited debuggee's image can stay locked for a moment after the session
// ends, so the first rmdir may hit EBUSY; rmSync retries EBUSY/EPERM with these options.
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 10, retryDelay: 200 });
// When even that is not enough (issue #866: Delve holds the image until its own exit,
// which the session's close does not wait for), the directory is left to the OS — it is
// under the temp dir, and a cleanup failure must not fail a test whose debugging passed.
try {
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 10, retryDelay: 200 });
} catch (err) {
const code = (err as NodeJS.ErrnoException).code;
if (code !== 'EBUSY' && code !== 'EPERM') {
throw err;
}
console.warn(`[go-exit-code] leaving ${tmp} to the OS: rmdir hit ${code} (issue #866)`);
}
}
}, 90_000);
});
Loading