Add provider-neutral TA/KYC evidence - #86
Open
0xMuang wants to merge 1 commit into
Open
Conversation
…r failing open Constraint: ERC-3643/ONCHAINID remain issuer-controlled external trust boundaries and no vendor API is assumed. Rejected: Vendor-specific adapter/mock promotion | would couple core to unverified provider contracts. Confidence: high Scope-risk: moderate Directive: Production must supply authenticated provider adapter, transactional HA store/WORM audit, and issuer-approved claim writer. Tested: compliance-data npm, AcquisitionSource 8, BUIDLLikeFlow 7, identity/claim Elements 8, hostile 8, diff Not-tested: scripts/check blocked by pre-existing forge fmt drift in script/DeployProductionCore.s.sol and script/DemoScenarios.s.sol; E2E skipped to preserve deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked dependency
Depends on #84 (
feature/rfq-durable-coordinator) and #85 (feature/rfq-service-hardening). This PR is intentionally based onfeature/rfq-service-hardening, notmain.Scope
services/compliance-data.Tests / validation
npm test --prefix services/compliance-data— passes.forge test --offline --match-contract AcquisitionSourceTest— 8 passed.forge test --offline --match-contract BUIDLLikeFlowTest— 7 passed.forge test --offline --match-test claim— 8 passed.forge test --offline --match-test identity— 4 passed.forge test --offline --match-contract ElementsTest— 19 passed.forge test --offline --match-test hostile— no Foundry tests found; hostile provider cases are covered by the compliance-data smoke tests.git diff --cached --check— clean before commit.contracts.md,deployments/, anddesc.mdwere preserved and not staged.Known blocker / not tested
scripts/check.shremains blocked by pre-existing forge fmt drift inscript/DeployProductionCore.s.solandscript/DemoScenarios.s.sol.deployments/artifacts.Production boundaries
No merge into
mainis requested here.