Skip to content

Add provider-neutral TA/KYC evidence - #86

Open
0xMuang wants to merge 1 commit into
feature/rfq-service-hardeningfrom
feature/provider-neutral-ta-kyc
Open

Add provider-neutral TA/KYC evidence#86
0xMuang wants to merge 1 commit into
feature/rfq-service-hardeningfrom
feature/provider-neutral-ta-kyc

Conversation

@0xMuang

@0xMuang 0xMuang commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Stacked dependency

Depends on #84 (feature/rfq-durable-coordinator) and #85 (feature/rfq-service-hardening). This PR is intentionally based on feature/rfq-service-hardening, not main.

Scope

  • Adds provider-neutral TA/KYC evidence normalization to services/compliance-data.
  • Produces PII-free evidence hashes and canonical payload hashes without committing raw provider payloads or investor PII.
  • Fails closed on provider outage, stale evidence, rejected decisions, mismatched subject/asset, unsupported provider, invalid freshness, or malformed inputs.
  • Documents provider-neutral onboarding/testing expectations and updates FEATURES, PROGRESS, QUALITY, and compliance-data README.

Tests / validation

  • npm test --prefix services/compliance-data — passes.
  • forge test --offline --match-contract AcquisitionSourceTest — 8 passed.
  • forge test --offline --match-contract BUIDLLikeFlowTest — 7 passed.
  • forge test --offline --match-test claim — 8 passed.
  • forge test --offline --match-test identity — 4 passed.
  • forge test --offline --match-contract ElementsTest — 19 passed.
  • forge test --offline --match-test hostile — no Foundry tests found; hostile provider cases are covered by the compliance-data smoke tests.
  • git diff --cached --check — clean before commit.
  • Staged secret/scratch scan completed; existing untracked contracts.md, deployments/, and desc.md were preserved and not staged.

Known blocker / not tested

  • scripts/check.sh remains blocked by pre-existing forge fmt drift in script/DeployProductionCore.s.sol and script/DemoScenarios.s.sol.
  • Full E2E was skipped in this integration step to preserve existing untracked deployments/ artifacts.

Production boundaries

  • ERC-3643 / ONCHAINID remain issuer-controlled external trust boundaries.
  • This PR does not assume or endorse a vendor API contract.
  • Production deployment must provide an authenticated provider adapter, transactional HA evidence store, WORM/SIEM audit path, and issuer-approved claim writer before live claim issuance.

No merge into main is requested here.

…r failing open

Constraint: ERC-3643/ONCHAINID remain issuer-controlled external trust boundaries and no vendor API is assumed.
Rejected: Vendor-specific adapter/mock promotion | would couple core to unverified provider contracts.
Confidence: high
Scope-risk: moderate
Directive: Production must supply authenticated provider adapter, transactional HA store/WORM audit, and issuer-approved claim writer.
Tested: compliance-data npm, AcquisitionSource 8, BUIDLLikeFlow 7, identity/claim Elements 8, hostile 8, diff
Not-tested: scripts/check blocked by pre-existing forge fmt drift in script/DeployProductionCore.s.sol and script/DemoScenarios.s.sol; E2E skipped to preserve deployments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant