Skip to content

Conversation

@jgongd
Copy link
Contributor

@jgongd jgongd commented Mar 17, 2025

We had labeled release candidates (RCs) as pre-releases, which cluttered the repo's release page. It's not easy to find the final version. To address this, RCs are labeled as drafts. This commit allows the Github Action publish-helm trigger by RC and upload RC helm chart to the helm repo.

Relevent Github webhook event doc: https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=created#release

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

We had labeled release candidates (RCs) as pre-releases, which
cluttered the repo's release page. It's not easy to find the final
version. To address this, RCs are labeled as drafts. This commit
allows the Github Action `publish-helm` trigger by RC and upload
RC helm chart to the helm repo.
@jgongd jgongd requested a review from maxrussell March 17, 2025 15:53
@jgongd jgongd requested a review from a team as a code owner March 17, 2025 15:53
@jgongd jgongd requested a review from molinamelendezj March 17, 2025 15:53
@cla-bot cla-bot bot added the cla-signed label Mar 17, 2025
@netlify
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ac34f2f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67d84581bdcef100082e9ee7

@jgongd jgongd merged commit 1786758 into main Mar 17, 2025
82 of 94 checks passed
@jgongd jgongd deleted the jgong/update-publish-helm-chart-ci branch March 17, 2025 16:29
jgongd added a commit that referenced this pull request Mar 19, 2025
We had labeled release candidates (RCs) as pre-releases, which
cluttered the repo's release page. It's not easy to find the final
version. To address this, RCs are labeled as drafts. This commit
allows the Github Action `publish-helm` trigger by RC and upload
RC helm chart to the helm repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants