Skip to content

docs: improve readme #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

docs: improve readme #24

wants to merge 9 commits into from

Conversation

jcbhmr
Copy link
Member

@jcbhmr jcbhmr commented Jun 6, 2023

closes #6

This doesn't remove the under construction banner (since we don't have anything to show for this repo yet), but it does add some badly needed content to the readme!

@jcbhmr jcbhmr added the documentation Improvements or additions to documentation label Jun 6, 2023
@jcbhmr jcbhmr requested a review from eitsupi June 6, 2023 06:13
@jcbhmr jcbhmr self-assigned this Jun 6, 2023
@jcbhmr jcbhmr linked an issue Jun 6, 2023 that may be closed by this pull request
@jcbhmr jcbhmr changed the title 6 improve readme docs: improve readme Jun 6, 2023
@eitsupi
Copy link
Contributor

eitsupi commented Jun 6, 2023

We should merge #23 first.

@eitsupi eitsupi marked this pull request as draft June 6, 2023 06:49
@jcbhmr jcbhmr changed the base branch from main to add-dart-feature June 6, 2023 07:03
@jcbhmr jcbhmr mentioned this pull request Jun 6, 2023
@jcbhmr jcbhmr changed the base branch from add-dart-feature to main June 9, 2023 22:15
@jcbhmr jcbhmr marked this pull request as ready for review June 9, 2023 22:17
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.42s
✅ EDITORCONFIG editorconfig-checker 1 0 0.02s
✅ MARKDOWN markdownlint 1 0 0 0.55s
✅ MARKDOWN markdown-link-check 1 0 1.13s
✅ MARKDOWN markdown-table-formatter 1 0 0 0.25s
✅ REPOSITORY checkov yes no 9.74s
✅ REPOSITORY devskim yes no 0.63s
✅ REPOSITORY dustilock yes no 0.25s
✅ REPOSITORY gitleaks yes no 0.24s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY kics yes no 13.04s
✅ REPOSITORY secretlint yes no 0.7s
✅ REPOSITORY syft yes no 0.31s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates.
Could you fix points the linter pointed out?

@jcbhmr
Copy link
Member Author

jcbhmr commented Jun 10, 2023

Yep! I won't make the mistake of ignoring the linter again 😆

@jcbhmr
Copy link
Member Author

jcbhmr commented Jun 13, 2023

This PR is currently BLOCKED by the website link being a 404. This PR should not be merged until the website exists.

@jcbhmr
Copy link
Member Author

jcbhmr commented Jun 13, 2023

I've added some MarkdownLint disable comments:

<!-- markdownlint-disable MD041 MD033 -->

Why?

  • MD041: allow image to be first; the rule requires the first line be # Heading
  • MD033: allow inline HTML for centered image; the rule disallows HTML

@jcbhmr jcbhmr requested a review from eitsupi June 13, 2023 02:56
@eitsupi
Copy link
Contributor

eitsupi commented Jun 13, 2023

  • MD033: allow inline HTML for centered image; the rule disallows HTML

Note that only certain tags can be allowed.
https://github.com/rocker-org/rocker-versioned2/blob/30f354ba627c0148581426abd588b1e770802570/.markdownlint.yaml#L12-L13

@eitsupi
Copy link
Contributor

eitsupi commented Jun 26, 2023

@jcbhmr Could you take a look at this?

Copy link
Contributor

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to review the Linter settings as I commented above?

@eitsupi
Copy link
Contributor

eitsupi commented Jul 26, 2023

@jcbhmr Do you still plan to work on this project?

@jcbhmr jcbhmr closed this Aug 16, 2023
@jcbhmr jcbhmr deleted the 6-improve-readme branch August 16, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve readme
2 participants