Skip to content

refactor: Fix linter stuff #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2023
Merged

refactor: Fix linter stuff #28

merged 3 commits into from
Jun 6, 2023

Conversation

jcbhmr
Copy link
Member

@jcbhmr jcbhmr commented Jun 6, 2023

No description provided.

@jcbhmr jcbhmr added the bug Something isn't working label Jun 6, 2023
@jcbhmr jcbhmr requested a review from eitsupi June 6, 2023 22:12
@jcbhmr jcbhmr self-assigned this Jun 6, 2023
@jcbhmr jcbhmr marked this pull request as ready for review June 6, 2023 22:12
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.11s
✅ COPYPASTE jscpd yes no 1.76s
✅ EDITORCONFIG editorconfig-checker 8 0 0.04s
✅ JSON eslint-plugin-jsonc 4 0 0 1.51s
✅ JSON jsonlint 2 0 0.2s
✅ JSON prettier 4 0 0 0.53s
✅ JSON v8r 4 0 2.65s
⚠️ MARKDOWN markdownlint 2 0 5 0.47s
❌ MARKDOWN markdown-link-check 2 1 3.3s
✅ MARKDOWN markdown-table-formatter 2 0 0 0.29s
✅ REPOSITORY checkov yes no 14.02s
✅ REPOSITORY devskim yes no 0.7s
✅ REPOSITORY dustilock yes no 0.03s
✅ REPOSITORY gitleaks yes no 0.27s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY kics yes no 15.54s
✅ REPOSITORY secretlint yes no 0.76s
✅ REPOSITORY syft yes no 0.39s
✅ YAML prettier 1 0 0 0.66s
✅ YAML v8r 1 0 1.95s
✅ YAML yamllint 1 0 0.25s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@jcbhmr
Copy link
Member Author

jcbhmr commented Jun 6, 2023

The remaining errors are:

  • The .sh files aren't executable. This is OK since the devcontainers CLI and other tooling always does chmod +x for us. I don't know if we want to explicitly do this in-source? Maybe.
  • The readme. Currently undergoing revamp docs: improve readme #24
  • The CI test workflow because it has write-all. Don't know whether we want to change this?

@eitsupi
Copy link
Contributor

eitsupi commented Jun 6, 2023

The CI test workflow because it has write-all. Don't know whether we want to change this?

Pls set permission like #27

@eitsupi eitsupi changed the title Fix linter stuff refactor: Fix linter stuff Jun 6, 2023
Copy link
Contributor

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcbhmr jcbhmr merged commit 0ce10c8 into main Jun 6, 2023
@jcbhmr jcbhmr deleted the fix-linter branch June 6, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants