Skip to content

refactor: Fix linter stuff #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"image": "mcr.microsoft.com/devcontainers/javascript-node",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker": {}
},
"postCreateCommand": "npm install -g @devcontainers/cli",
"customizations": {
"vscode": {
"extensions": ["mads-hartmann.bash-ide-vscode"]
}
}
"image": "mcr.microsoft.com/devcontainers/javascript-node",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker": {}
},
"postCreateCommand": "npm install -g @devcontainers/cli",
"customizations": {
"vscode": {
"extensions": ["mads-hartmann.bash-ide-vscode"]
}
}
}
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ on:
- main
pull_request:
workflow_dispatch:

permissions:
contents: read
jobs:
test-autogenerated:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
megalinter-reports
logs
*.log
12 changes: 6 additions & 6 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"json.schemas": [
{
"fileMatch": ["*/devcontainer-feature.json"],
"url": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainerFeature.schema.json"
}
]
"json.schemas": [
{
"fileMatch": ["*/devcontainer-feature.json"],
"url": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainerFeature.schema.json"
}
]
}
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ my favorite color is green

## Repo and Feature Structure

Similar to the [`devcontainers/features`](https://github.com/devcontainers/features) repo, this repository has a `src` folder. Each Feature has its own sub-folder, containing at least a `devcontainer-feature.json` and an entrypoint script `install.sh`.
Similar to the [`devcontainers/features`](https://github.com/devcontainers/features) repo, this repository has a `src` folder. Each Feature has its own sub-folder, containing at least a `devcontainer-feature.json` and an entrypoint script `install.sh`.

```
├── src
Expand Down Expand Up @@ -149,7 +149,7 @@ https://github.com/users/<owner>/packages/container/<repo>%2F<featureName>/setti
If you'd like your Features to appear in our [public index](https://containers.dev/features) so that other community members can find them, you can do the following:

* Go to [github.com/devcontainers/devcontainers.github.io](https://github.com/devcontainers/devcontainers.github.io)
* This is the GitHub repo backing the [containers.dev](https://containers.dev/) spec site
* This is the GitHub repo backing the [containers.dev](https://containers.dev/) spec site
* Open a PR to modify the [collection-index.yml](https://github.com/devcontainers/devcontainers.github.io/blob/gh-pages/_data/collection-index.yml) file

This index is from where [supporting tools](https://containers.dev/supporting) like [VS Code Dev Containers](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) and [GitHub Codespaces](https://github.com/features/codespaces) surface Features for their dev container creation UI.
Expand Down
89 changes: 44 additions & 45 deletions src/dart/NOTES.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,44 @@
<!-- markdownlint-disable MD041 MD033 -->

<div align="center">

[![Dart website](https://thum.io/get/width/800/crop/600/noanimate/https://dart.dev/)](https://dart.dev/)

</div>

> Dart is a client-optimized language for fast apps on any platform

&mdash; [Dart programming language | Dart]

This feature installs the Dart SDK.

🆘 If you're having trouble with this feature, [open a Discussion] or [open an
Issue]! We'd be happy to fix bugs! 🐛

## Supported platforms

`linux/amd64` and `linux/arm64` platforms `debian` and `ubuntu`.

## How to specify extensions?

This feature installs any version with the `version` option and `channel` option.
Check [Dart SDK archive] for channel details.

```json
"features": {
"ghcr.io/devcontainers-community/features/dart:1": {
"version": "3",
"channel": "beta"
}
}
```

Note that the beta and dev channels use suffix-based version matching,
so only versions ending with channel name (e.g. `3.1.0-63.1.beta`) can be installed.

<!-- prettier-ignore-start -->
[Dart programming language | Dart]: https://dart.dev/
[Dart SDK archive]: https://dart.dev/get-dart/archive
[Flutter]: https://flutter.dev/
[open a Discussion]: https://github.com/devcontainers-community/features/discussions/new?category=q-a
[open an Issue]: https://github.com/devcontainers-community/features/issues/new
<!-- prettier-ignore-end -->
<!-- markdownlint-disable MD041 MD033 -->

<div align="center">

[![Dart website](https://thum.io/get/width/800/crop/600/noanimate/https://dart.dev/)](https://dart.dev/)

</div>

> Dart is a client-optimized language for fast apps on any platform

&mdash; [Dart programming language | Dart]

This feature installs the Dart SDK.

🆘 If you're having trouble with this feature, [open a Discussion] or [open an
Issue]! We'd be happy to fix bugs! 🐛

## Supported platforms

`linux/amd64` and `linux/arm64` platforms `debian` and `ubuntu`.

## How to specify extensions?

This feature installs any version with the `version` option and `channel` option.
Check [Dart SDK archive] for channel details.

```json
"features": {
"ghcr.io/devcontainers-community/features/dart:1": {
"version": "3",
"channel": "beta"
}
}
```

Note that the beta and dev channels use suffix-based version matching,
so only versions ending with channel name (e.g. `3.1.0-63.1.beta`) can be installed.

<!-- prettier-ignore-start -->
[Dart programming language | Dart]: https://dart.dev/
[Dart SDK archive]: https://dart.dev/get-dart/archive
[open a Discussion]: https://github.com/devcontainers-community/features/discussions/new?category=q-a
[open an Issue]: https://github.com/devcontainers-community/features/issues/new
<!-- prettier-ignore-end -->
56 changes: 28 additions & 28 deletions src/dart/devcontainer-feature.json
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
{
"id": "dart",
"name": "Dart",
"description": "Installs the Dart SDK",
"version": "1.0.0",
"options": {
"version": {
"description": "Select version of Dart SDK",
"type": "string",
"default": "latest",
"proposals": ["latest", "3"]
},
"channel": {
"description": "Select build channel of Dart SDK",
"type": "string",
"default": "stable",
"enum": ["stable", "beta", "dev", "main"]
}
},
"containerEnv": {
"PATH": "/usr/lib/dart/bin:${PATH}"
},
"customizations": {
"vscode": {
"extensions": ["dart-code.dart-code"]
}
}
}
{
"id": "dart",
"name": "Dart",
"description": "Installs the Dart SDK",
"version": "1.0.0",
"options": {
"version": {
"description": "Select version of Dart SDK",
"type": "string",
"default": "latest",
"proposals": ["latest", "3"]
},
"channel": {
"description": "Select build channel of Dart SDK",
"type": "string",
"default": "stable",
"enum": ["stable", "beta", "dev", "main"]
}
},
"containerEnv": {
"PATH": "/usr/lib/dart/bin:${PATH}"
},
"customizations": {
"vscode": {
"extensions": ["dart-code.dart-code"]
}
}
}
48 changes: 24 additions & 24 deletions test/dart/scenarios.json
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
{
"version-3": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"dart": {
"version": "3"
}
}
},
"channel-beta": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"dart": {
"channel": "beta"
}
}
},
"channel-main": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"dart": {
"channel": "main"
}
}
}
"version-3": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"dart": {
"version": "3"
}
}
},
"channel-beta": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"dart": {
"channel": "beta"
}
}
},
"channel-main": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"dart": {
"channel": "main"
}
}
}
}