-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add workflows and cli-style #52
Conversation
🚀 Deployed on https://pr-52.climate-app.netlify.dhis2.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I made one functional refactor to satisfy the no-async-promise-executor rule for ESlint -- @turban The diff is a bit hard to read because of the indenting changes, but it'd be good to have a look and make sure that's still working 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The promise refactor works fine.
🎉 This PR is included in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds workflows:
test-and-release
:@dhis2/cli-style
, regular code linting, unit tests, (optional e2e tests)d2-ci
deploy-pr
: on PRs, deploys a preview dev version on Netlifylint-pr-title
: makes sure it matches conventional commit formatcomment-and-close
: If someone opens up an issue on this repo, a bot will close it and direct the opener to JiraAdds style tools:
import/extensions
,max-params
, andno-unused-vars
; I made those 'warning'-level issues in.eslintrc.js
to avoid blocking the PRd2-style
lintersI tried adding stylelint, but I think there's a bug with it that causes it to throw errors 🤔