Skip to content

Conversation

@AldaronLau
Copy link

I know this is changed in the master branch, but it would be nice to have on 1.4.x as well, considering that 2.0.0 isn't out yet.

@weiznich
Copy link
Member

weiznich commented Mar 8, 2022

Thanks for submitting this PR. As of today we do not plan to issue another 1.4.x release. That's reserved for finding a critical bug that needs to be fixed. I consider this feature to be a nice to have change so I would include it in an already planed release, but won't cut a new release for it. As of this I will leave this PR open till either 2.0 is released or we cut another 1.4.x release.
That written: The CI failures look legit. A requirement for maybe including this into a release would be a passing CI.

@AldaronLau AldaronLau force-pushed the v1.4.8-remove-time branch from dfee628 to 0fe3cea Compare March 9, 2022 04:16
@AldaronLau
Copy link
Author

@weiznich Updated PR to add required chrono/clock feature, but CI is still failing on some of the checks for odd reasons.

Also, I looked but couldn't find - is there a roadmap or timeline for the 2.0.0 release?

@weiznich
Copy link
Member

weiznich commented Mar 9, 2022

Also, I looked but couldn't find - is there a roadmap or timeline for the 2.0.0 release?

We do not have a public roadmap or timeline for the next release, but I would say it shouldn't be to far away (at least a rc release). Open issues/PR's that are relevant are: #2996, #3021 and some sort of fix for #3016. Any help there would be welcome and would enable an earlier release.

@weiznich
Copy link
Member

weiznich commented Mar 9, 2022

About the CI errors: The sqlite and mysql cases would likely require a backport of #3052. The compile tests ci run points out a real issue. The minimal supported chrono version does not have the relevant feature. This likely indicates we would need to bump that minimal version, which is something that is not possible as patch release. (Strictly speaking that would require a major version bump)

@weiznich
Copy link
Member

Closed as 2.0.0 is finally released. It does contain this fix.

@weiznich weiznich closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants