Backporting sqlite read_blob fix to version 1.4.X to unblock the build with address sanitizer #3077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the build with address sanitizer
Member
|
Strictly speaking we do only backport critical bugfixes to the 1.4.x release. That change is something I would not classify as critical bug fix as it requires manually building rust-stdlib. Similar to #3074 I would be fine with including this into a release which would happen nevertheless. That means I will leave this PR open till we either issue another 1.4.x release or we release a first 2.0.0 version. That written: I prerequisite for including this into a release would be that the CI passes. |
Member
|
Closed as 2.0.0 is finally released. It does contain this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original fix in master: PR