Skip to content

Backporting sqlite read_blob fix to version 1.4.X to unblock the build with address sanitizer #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kgrech wants to merge 1 commit into from
Closed

Backporting sqlite read_blob fix to version 1.4.X to unblock the build with address sanitizer #3077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion diesel/src/sqlite/connection/sqlite_value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ impl SqliteValue {
unsafe {
let ptr = ffi::sqlite3_value_blob(self.value());
let len = ffi::sqlite3_value_bytes(self.value());
slice::from_raw_parts(ptr as *const u8, len as usize)
if len == 0 {
// rusts std-lib has an debug_assert that prevents creating
// slices without elements from a pointer
&[]
} else {
slice::from_raw_parts(ptr as *const u8, len as usize)
}
}
}

Expand Down