Skip to content

Update version to 1.3.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

ellisbow
Copy link
Contributor

@ellisbow ellisbow commented Jan 8, 2025

Adds the MaintainedByDiffblue interface. This is an empty interface that is require when using the @Category annotation for marking JUnit 4 tests.

Required for tagging JUnit 4 tests
This is part of the release process
@ellisbow ellisbow requested a review from a team January 8, 2025 14:17
* Empty interface, required, with the Category annotation, to label JUnit 4 tests in the following
* manner: @Category(MaintainedByDiffblue.class)
*/
public interface MaintainedByDiffblue {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ This is probably something you thought through/tried but I would rather ask - is it enough to have this as an interface or does it need to be a class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be either. The original documentation I found had it as an interface so I did that but I've tested it as a class as well

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, if the suggestion in docs is to use an interface (or if JUnit itself uses it) then presumably that's better standard 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of class, interface, enum or annotation would do, in fact (or even a record in Java 17 or later) - all we need is that we can get a Class object for it.

@@ -16,7 +16,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.diffblue.cover</groupId>
<artifactId>cover-annotations</artifactId>
<version>1.2.0</version>
<version>1.3.0</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasPerkins1123 from process point of view, are you happy for this commit to be part of the same PR or should it be a standalone PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am happy with this on this repo, as long as its always its own commit

@majakusber
Copy link

Oh I just noticed that the PR title could be improved, minor thing, otherwise go for it 👍

@ellisbow ellisbow merged commit 56f1b3c into develop Jan 9, 2025
1 check passed
@ellisbow ellisbow deleted the ellisbow/TG-22489-maintainedbydiffblue branch January 9, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants