Skip to content

Update version to 1.3.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Update version to 1.3.0 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55d5bd9
Add MaintainedByDiffblue interface.
ellisbow Jan 8, 2025
eeb1299
Update to version 1.3.0
ellisbow Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.diffblue.cover</groupId>
<artifactId>cover-annotations</artifactId>
<version>1.2.0</version>
<version>1.3.0</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasPerkins1123 from process point of view, are you happy for this commit to be part of the same PR or should it be a standalone PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am happy with this on this repo, as long as its always its own commit

<packaging>jar</packaging>

<name>Cover Annotations</name>
Expand Down
21 changes: 21 additions & 0 deletions src/main/java/com/diffblue/cover/annotations/MaintainedByDiffblue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
* Copyright 2025 Diffblue Limited.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/
package com.diffblue.cover.annotations;

/**
* Empty interface, required, with the Category annotation, to label JUnit 4 tests in the following
* manner: @Category(MaintainedByDiffblue.class)
*/
public interface MaintainedByDiffblue {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ This is probably something you thought through/tried but I would rather ask - is it enough to have this as an interface or does it need to be a class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be either. The original documentation I found had it as an interface so I did that but I've tested it as a class as well

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, if the suggestion in docs is to use an interface (or if JUnit itself uses it) then presumably that's better standard 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of class, interface, enum or annotation would do, in fact (or even a record in Java 17 or later) - all we need is that we can get a Class object for it.

Loading