Add total number of SQL and Redis calls #356
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
MethodProfiler, bothdurationandcallsare tracked, but onlydurationis reported.Based on the fact that
WebCollectorusesPrometheusExporter::Metric::Base.default_aggregation, which is aSummary, I imagine this was accidentally omitted based on a misunderstanding that the*_countmetric would contain the value ofcalls. Instead, the middleware pre-aggregates durations for the request, so the*_countmetrics only increment by 1 and AFAICT thecallsvalue is never used.This PR reports the
callsvalue.