Skip to content

Conversation

@jgaskins
Copy link

In MethodProfiler, both duration and calls are tracked, but only duration is reported.

Based on the fact that WebCollector uses PrometheusExporter::Metric::Base.default_aggregation, which is a Summary, I imagine this was accidentally omitted based on a misunderstanding that the *_count metric would contain the value of calls. Instead, the middleware pre-aggregates durations for the request, so the *_count metrics only increment by 1 and AFAICT the calls value is never used.

This PR reports the calls value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant