Skip to content

Add total number of SQL and Redis calls #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Add total number of SQL and Redis calls #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/prometheus_exporter/server/web_collector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ def initialize
@http_requests_total = nil
@http_request_duration_seconds = nil
@http_request_redis_duration_seconds = nil
@http_request_redis_calls = nil
@http_request_sql_duration_seconds = nil
@http_request_sql_calls = nil
@http_request_queue_duration_seconds = nil
@http_request_memcache_duration_seconds = nil
end
Expand Down Expand Up @@ -47,12 +49,23 @@ def ensure_metrics
"Time spent in HTTP reqs in Redis, in seconds.",
)

@metrics["http_request_redis_calls"] = @http_request_redis_calls =
PrometheusExporter::Metric::Counter.new(
"http_request_redis_calls",
"Total number of Redis calls made inside an HTTP request.",
)

@metrics["http_request_sql_duration_seconds"] = @http_request_sql_duration_seconds =
PrometheusExporter::Metric::Base.default_aggregation.new(
"http_request_sql_duration_seconds",
"Time spent in HTTP reqs in SQL in seconds.",
)

@metrics["http_request_sql_calls"] = @http_request_sql_calls = PrometheusExporter::Metric::Counter.new(
"http_request_sql_calls",
"The total number of SQL queries made inside an HTTP request."
)

@metrics[
"http_request_memcache_duration_seconds"
] = @http_request_memcache_duration_seconds =
Expand Down Expand Up @@ -80,9 +93,11 @@ def observe(obj)
@http_request_duration_seconds.observe(timings["total_duration"], labels)
if redis = timings["redis"]
@http_request_redis_duration_seconds.observe(redis["duration"], labels)
@http_request_redis_calls.increment(labels, redis["calls"])
end
if sql = timings["sql"]
@http_request_sql_duration_seconds.observe(sql["duration"], labels)
@http_request_sql_calls.increment(labels, sql["calls"])
end
if memcache = timings["memcache"]
@http_request_memcache_duration_seconds.observe(memcache["duration"], labels)
Expand Down