Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 23, 2025

This PR adds deprecation notices for the std.lib.dev.mkMakes function following the deprecation of the fluidattacks/makes project in favor of Nix Flakes.

Changes

Runtime Warning: Added a builtins.trace deprecation warning to src/lib/dev/mkMakes.nix that displays when the function is used:

⚠️  DEPRECATION WARNING: std.lib.dev.mkMakes is deprecated

The fluidattacks/makes project has been deprecated in favor of Nix Flakes.
Scheduled for removal: 2025-06-01

Please migrate your makes tasks to use native Nix derivations or other
Standard-supported alternatives.

Documentation Updates:

  • Updated src/lib/dev/mkMakes.md with prominent deprecation warning in the function title and description
  • Added the deprecation to the formal deprecation registry in deprecation.nix
  • Updated the README.md integration badge to show deprecated status (red color)

Migration Path: The changes maintain backward compatibility while clearly warning users about the deprecation and providing a scheduled removal date of 2025-06-01. Users can continue using the function while planning their migration to native Nix solutions.

This addresses the fluidattacks/makes project deprecation and provides users with clear guidance for migration away from the deprecated tooling.

Fixes #413.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • install.determinate.systems
    • Triggering command: curl --proto =https --tlsv1.2 -sSf -L https://install.determinate.systems/nix (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] fluidattacks/makes is deprecated Add deprecation notice for fluidattacks/makes integration Aug 23, 2025
@Copilot Copilot AI requested a review from blaggacao August 23, 2025 16:28
Copilot finished work on behalf of blaggacao August 23, 2025 16:28
Copy link
Collaborator

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please incorporate the requested changes.

@@ -1,4 +1,14 @@
inputs: let
removeBy = import ./cells/std/errors/removeBy.nix {inherit inputs;};
in {
# fluidattacks/makes integration deprecation
mkMakes = removeBy "2025-06-01" ''
Copy link
Collaborator

@blaggacao blaggacao Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the date to something in 2026 as the removal date @copilot

Copy link
Collaborator

@blaggacao blaggacao Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this entire implementation over to the deprecation.nix file. Then back-import it here. Keep your deprecation warning in the deprecation.nix file @copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluidattacks/makes is deprecated
2 participants