Skip to content

Add deprecation notice for fluidattacks/makes integration #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −2
Draft

Add deprecation notice for fluidattacks/makes integration #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce9d483
Initial plan
Copilot Aug 23, 2025
7864575
Add deprecation notice for fluidattacks/makes integration
Copilot Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ quality vertical DevOps tooling crafted by the [Nix Ecosystem][ecosystem].
[![Numtide Devshell](https://img.shields.io/badge/Numtide-Devshell-yellowgreen?style=for-the-badge&logo=NixOS)](https://github.com/numtide/devshell)
[![Numtide Treefmt](https://img.shields.io/badge/Numtide-Treefmt-yellow?style=for-the-badge&logo=NixOS)](https://github.com/numtide/treefmt)
[![Nlewo Nix2Container](https://img.shields.io/badge/Nlewo-Nix2Container-blue?style=for-the-badge&logo=NixOS)](https://github.com/nlewo/nix2container)
[![Fluidattacks Makes](https://img.shields.io/badge/Fluidattacks-Makes-blue?style=for-the-badge&logo=NixOS)](https://github.com/fluidattacks/makes)
[![Fluidattacks Makes (DEPRECATED)](https://img.shields.io/badge/Fluidattacks-Makes%20(DEPRECATED)-red?style=for-the-badge&logo=NixOS)](https://github.com/fluidattacks/makes)
[![Astro MicroVM](https://img.shields.io/badge/Astro-MicroVM-blue?style=for-the-badge&logo=NixOS)](https://github.com/astro/microvm.nix)
[![HerculesCI FlakeParts](https://img.shields.io/badge/HerculesCI-FlakeParts-lightgrey?style=for-the-badge&logo=NixOS)](https://github.com/hercules-ci/flake-parts)
[![Cachix Cache](https://img.shields.io/badge/Cachix-Cache-blue?style=for-the-badge&logo=NixOS)](https://github.com/cachix)
Expand Down
10 changes: 10 additions & 0 deletions deprecation.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
inputs: let
removeBy = import ./cells/std/errors/removeBy.nix {inherit inputs;};
in {
# fluidattacks/makes integration deprecation
mkMakes = removeBy "2025-06-01" ''
Copy link
Collaborator

@blaggacao blaggacao Aug 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the date to something in 2026 as the removal date @copilot

std.lib.dev.mkMakes is deprecated.

The fluidattacks/makes project has been deprecated in favor of Nix Flakes.
Please migrate your makes tasks to use native Nix derivations or other
Standard-supported alternatives.

For more information, see: https://github.com/fluidattacks/makes
'';
}
4 changes: 3 additions & 1 deletion src/lib/dev/mkMakes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
### `mkMakes`
### `mkMakes` (DEPRECATED)

> **⚠️ DEPRECATION WARNING**: This function is deprecated as of 2024 and scheduled for removal on 2025-06-01. The [`fluidattacks/makes`][makes] project has been deprecated in favor of Nix Flakes. Please migrate your makes tasks to use native Nix derivations or other Standard-supported alternatives.

... provides an interface to `makes` tasks

Expand Down
13 changes: 13 additions & 0 deletions src/lib/dev/mkMakes.nix
View file
Open in desktop
Copy link
Collaborator

@blaggacao blaggacao Aug 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this entire implementation over to the deprecation.nix file. Then back-import it here. Keep your deprecation warning in the deprecation.nix file @copilot

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,19 @@ let
inherit (inputs.cells.std.errors) requireInput;
inherit (requireInput "makes" "github:fluidattacks/makes" "std.lib.dev.mkMakes") nixpkgs makes;
inherit (inputs.nixpkgs.lib) customisation fix extends;

# Show deprecation warning
_ = builtins.trace ''
⚠️ DEPRECATION WARNING: std.lib.dev.mkMakes is deprecated

The fluidattacks/makes project has been deprecated in favor of Nix Flakes.
Scheduled for removal: 2025-06-01

Please migrate your makes tasks to use native Nix derivations or other
Standard-supported alternatives.

For more information, see: https://github.com/fluidattacks/makes
'' null;
in
customisation.callPackageWith (fix (
extends (
Expand Down