-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: make transactionNestingLevel
for easier overriding
#7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.3.x
Are you sure you want to change the base?
Conversation
May I also remove the |
return $this->handleDriverException($e, new Query($sql, $params, $types)); | ||
} | ||
|
||
/** @internal */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where else is this method expected to be invoked from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morozov I used the convertException
method from the connect
and commit
methods that I overrode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morozov Another solution would be to make the handleDriverException
method protected
instead of private
.
I don't think this is a good idea. It would make the shape of |
@morozov Okay, in that case, do you have any idea how I can silence the deprecation message that indicates the class is internal? |
What does this message look like? I don't think the DBAL itself emits any messages when an internal method is invoked from outside. It must be some 3rd-party tooling. |
Yep it's the I have no clue what this class does though. ![]() |
Summary
See #6885