Skip to content

refactor: make transactionNestingLevel for easier overriding #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.3.x
Choose a base branch
from
Open

refactor: make transactionNestingLevel for easier overriding #7145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class Connection implements ServerVersionProvider
/**
* The transaction nesting level.
*/
private int $transactionNestingLevel = 0;
protected int $transactionNestingLevel = 0;

/**
* The currently active transaction isolation level or NULL before it has been determined.
Expand Down Expand Up @@ -1392,7 +1392,6 @@ final public function convertExceptionDuringQuery(
return $this->handleDriverException($e, new Query($sql, $params, $types));
}

/** @internal */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where else is this method expected to be invoked from?

Copy link
Author

@Crovitche-1623 Crovitche-1623 Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morozov I used the convertException method from the connect and commit methods that I overrode.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morozov Another solution would be to make the handleDriverException method protected instead of private.

final public function convertException(Driver\Exception $e): DriverException
{
return $this->handleDriverException($e, null);
Expand Down