Prepare release: v1.2.0 #3015
Prepare release: v1.2.0 #3015
Conversation
WalkthroughOhayo, sensei! This PR uniformly bumps the version numbers for several Rust package configuration files. The workspace's main Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Cargo.toml (1)
239-240: Ohayo sensei! Let's investigate this TODO.There's a TODO comment suggesting to review if the git dependency for
ipfs-api-backend-hyperis still needed. Would you like me to help investigate alternatives or create an issue to track this?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
Cargo.lockis excluded by!**/*.lockcrates/dojo/core/Scarb.lockis excluded by!**/*.lockcrates/torii/types-test/Scarb.lockis excluded by!**/*.lockexamples/spawn-and-move/Scarb.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml(1 hunks)crates/dojo/core/Scarb.toml(1 hunks)crates/torii/types-test/Scarb.toml(1 hunks)examples/spawn-and-move/Scarb.toml(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- crates/dojo/core/Scarb.toml
- crates/torii/types-test/Scarb.toml
- examples/spawn-and-move/Scarb.toml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: fmt
| @@ -58,7 +58,7 @@ edition = "2021" | |||
| license = "Apache-2.0" | |||
| license-file = "LICENSE" | |||
| repository = "https://github.com/dojoengine/dojo/" | |||
| version = "1.1.2" | |||
| version = "1.2.0" | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Ohayo sensei! Version bump looks good.
The version increment from 1.1.2 to 1.2.0 follows semantic versioning principles, indicating new backward-compatible features.
Let's verify version consistency across all Scarb.toml files:
🏁 Script executed:
#!/bin/bash
# Description: Check version consistency across all Scarb.toml files
echo "Checking version consistency..."
find . -name "Scarb.toml" -type f -exec grep -H "version = " {} \;Length of output: 1369
Ohayo sensei! Cargo.toml’s version bump from "1.1.2" to "1.2.0" looks solid, but please double-check the version consistency across your Scarb.toml files.
- The main package update clearly follows semantic versioning.
- However, our check shows that while a few Scarb.toml files (like in
./examples/spawn-and-move,./crates/torii/types-test, and./crates/dojo/core) are updated to "1.2.0", many others remain on older versions (e.g., "0.1.0", "1.0.12", "1.0.0-rc.0", "0.3.1-rc7"). - Please confirm if these differences are intentional. If a unified bump is expected for a v1.2.0 release, update the mismatched Scarb.toml files accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
=======================================
Coverage 56.21% 56.21%
=======================================
Files 436 436
Lines 58737 58737
=======================================
+ Hits 33019 33021 +2
+ Misses 25718 25716 -2 ☔ View full report in Codecov by Sentry. |
This reverts commit d54848b.
This reverts commit 1ebd917.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
testfunction from theSimpleMathinterface, streamlining the library's functionality.