Merge | Cleanup Pre 2005 Support in TdsParser #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helZ/SqlClient into pr/tdsparser-remove-sql-2000
benrr101
added
Code Health 💊
mdaigle
requested changes
Mar 7, 2025
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
paulmedynski
approved these changes
Mar 7, 2025
- Removing _is2005 - Removing ENV_CHANGE types that are not supported in TDS >7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
===========================================
+ Coverage 72.57% 92.58% +20.00%
===========================================
Files 288 6 -282
Lines 59526 310 -59216
===========================================
- Hits 43201 287 -42914
+ Misses 16325 23 -16302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Mar 10, 2025
cheenamalhotra
approved these changes
Mar 10, 2025
Wraith2
pushed a commit
to Wraith2/SqlClient
that referenced
this pull request
Mar 11, 2025
* Cleanup Pre 2005 Support in TdsParser * Fix some code indentation issues * Fix some code indentation issues * Add back isVersion8 * PR Comments - Removing _is2005 - Removing ENV_CHANGE types that are not supported in TDS >7 --------- Co-authored-by: Michel Zehnder <[email protected]> Co-authored-by: Cheena Malhotra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilding #3085 under the dotnet repo in order to complete full CI, original description is as follows
Now that #2839 is merged, the Pre 2005 Code can be removed from netfx to align netfx & netcore code for future merge of TdsParser.
It also removes asserts that were used to gate 2005-only code
The code does not aim to remove Pre 2005 Code from other classes
This is working towards #2953