-
Notifications
You must be signed in to change notification settings - Fork 612
A few accessibility fixes #9017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few accessibility fixes #9017
Conversation
It's fine other than the color change. It looks worse. The new colors are too loud. I don't think the accent colors are what we want to use. An app typically has one accent color (Aspire's is purple). These are being used all together which doesn't work. I searched around and I came across this FluentUI charting library that has a bunch of colors used in data: https://microsoft.github.io/fluentui-charting-contrib/docs/colors#3-use-colors-from-palette I do like having slightly different colors for light and dark. Some of the current colors, e.g. dark blue, don't work well with the dark theme. |
Aside, not for this PR -- should we attempt to always use the same color for the same "kind" of thing? Eg., DB always red, cache always blue. |
@adamint if it helps speed you could break out the color changes from this PR and put those in a 2nd PR |
@danmoseley @JamesNK removed the color changes. Also added labels to two fluent tooltips |
Not a bad idea, I'd support this. |
Create an issue. There should be discussion about how exactly this could work. |
Opened #9039 |
Description
Adds an aria-label to three buttons where it was missing. Also horizontally-aligns property grid headers, as requested in the design review.
(after)

(before)

Fixes #8857 and part of #8827 and fixes #8858
Checklist
<remarks />
and<code />
elements on your triple slash comments?doc-idea
templatebreaking-change
templatediagnostic
template