Skip to content

A few accessibility fixes #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2025

Conversation

adamint
Copy link
Member

@adamint adamint commented Apr 29, 2025

Description

Adds an aria-label to three buttons where it was missing. Also horizontally-aligns property grid headers, as requested in the design review.

(after)
image

(before)
image

Fixes #8857 and part of #8827 and fixes #8858

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK
Copy link
Member

JamesNK commented Apr 29, 2025

It's fine other than the color change. It looks worse. The new colors are too loud.

I don't think the accent colors are what we want to use. An app typically has one accent color (Aspire's is purple). These are being used all together which doesn't work.

I searched around and I came across this FluentUI charting library that has a bunch of colors used in data: https://microsoft.github.io/fluentui-charting-contrib/docs/colors#3-use-colors-from-palette
These colors might be more approprate. Although I'm not sure that these colors would be an improvement. They still seem like they'd be too loud. Our current colors feel more pastel.

I do like having slightly different colors for light and dark. Some of the current colors, e.g. dark blue, don't work well with the dark theme.

@danmoseley
Copy link
Member

Aside, not for this PR -- should we attempt to always use the same color for the same "kind" of thing? Eg., DB always red, cache always blue.

@danmoseley
Copy link
Member

@adamint if it helps speed you could break out the color changes from this PR and put those in a 2nd PR

@adamint
Copy link
Member Author

adamint commented Apr 29, 2025

@danmoseley @JamesNK removed the color changes. Also added labels to two fluent tooltips

@adamint
Copy link
Member Author

adamint commented Apr 29, 2025

Aside, not for this PR -- should we attempt to always use the same color for the same "kind" of thing? Eg., DB always red, cache always blue.

Not a bad idea, I'd support this.

@JamesNK
Copy link
Member

JamesNK commented Apr 30, 2025

Aside, not for this PR -- should we attempt to always use the same color for the same "kind" of thing? Eg., DB always red, cache always blue.

Not a bad idea, I'd support this.

Create an issue. There should be discussion about how exactly this could work.

@danmoseley danmoseley merged commit 24d6188 into dotnet:main Apr 30, 2025
174 checks passed
@danmoseley
Copy link
Member

Opened #9039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants