[HTTP] Stress fix for docker compose #119274
Conversation
github-actions
bot
added
the
needs-area-label
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Docker Compose cleanup issue in the HTTP stress test pipeline by adding explicit docker-compose down commands after each stress test run. The change ensures proper resource cleanup between individual HTTP protocol version tests (3.0, 2.0, and 1.1) to prevent conflicts and failures in subsequent test runs.
Key changes:
- Added
docker-compose downcommand after each HTTP stress test execution - Applied consistently across all three HTTP protocol version tests (3.0, 2.0, 1.1)
ManickaP
added
area-System.Net.Http
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Http stress is green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1138189&view=results The fix is based on the second answer here: https://askubuntu.com/questions/1508129/docker-compose-giving-containerconfig-errors-after-update-today as we don't have |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/17544665607 |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17544677561 |
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17544683950 |
|
@ManickaP backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Wind down docker compose between individual runs in HTTP stress
Using index info to reconstruct a base tree...
M eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
Applying: Experiment 2
Using index info to reconstruct a base tree...
M eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/stress/http.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Experiment 2
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@ManickaP backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Wind down docker compose between individual runs in HTTP stress
Using index info to reconstruct a base tree...
M eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
Applying: Experiment 2
Using index info to reconstruct a base tree...
M eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/stress/http.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Experiment 2
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
* [HTTP] Stress fix for docker compose Backport of #119274 to release/10.0 /cc @ManickaP ## Customer Impact - [ ] Customer reported - [x] Found internally Wind down docker compose between individual runs in HTTP stress. ## Regression - [x] Yes - [ ] No Infra update. ## Testing CI stress runs. ## Risk Low. Test only change. * Remove unnecessary docker-compose down commands Removed 'docker-compose down' command from HTTP 1.1 and 2.0 stress test configurations.
* [HTTP] Stress fix for docker compose Backport of #119274 to release/10.0 /cc @ManickaP ## Customer Impact - [ ] Customer reported - [x] Found internally Wind down docker compose between individual runs in HTTP stress. ## Regression - [x] Yes - [ ] No Infra update. ## Testing CI stress runs. ## Risk Low. Test only change. * Add docker-compose down command before up
Wind down docker compose between individual runs in HTTP stress.
See logs for error: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/build/builds/1136356/logs/18
And test run of my branch that passed: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/build/builds/1137026/logs/17