Skip to content

Comments

Split GivenThatWeWantToRunILLink test class into multiple so Helix can run them separately#44973

Merged
akoeplinger merged 1 commit intodotnet:mainfrom
akoeplinger:split-illink-tests
Nov 20, 2024
Merged

Split GivenThatWeWantToRunILLink test class into multiple so Helix can run them separately#44973
akoeplinger merged 1 commit intodotnet:mainfrom
akoeplinger:split-illink-tests

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 20, 2024

Fixes #44895

Durations from this PR:

Durations from a random other PR (#44968):

@ghost ghost added Area-ILLink untriaged Request triage from a team member labels Nov 20, 2024
@akoeplinger akoeplinger marked this pull request as ready for review November 20, 2024 10:23
@akoeplinger akoeplinger requested a review from a team as a code owner November 20, 2024 10:23
}

internal static class ILLinkTestUtils
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the utility functions in the same file to minimize the diff but let me know if I should move it to a separate file

Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@akoeplinger akoeplinger merged commit d691b06 into dotnet:main Nov 20, 2024
@akoeplinger akoeplinger deleted the split-illink-tests branch November 20, 2024 20:44
@joeloff
Copy link
Member

joeloff commented Nov 23, 2024

/backport to release/9.0.2xx

@github-actions
Copy link
Contributor

Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/11982499885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-ILLink untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.NET.Publish.Tests.dll.5 is timing out a lot, imbalance with other partitions

4 participants