-
Notifications
You must be signed in to change notification settings - Fork 1k
Missing unit tests coverage of public methods in Design namespace #10773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment has been minimized.
This comment has been minimized.
@SimonZhao888 - could you please use this bug only for public classes from System.Windows.Forms.Design namespace - https://github.com/dotnet/winforms/tree/main/src/System.Windows.Forms.Design/src? And then add help-wanted label. We will use this bug to track tests added by contributors. |
Also remember the goal here isn't to increase code coverage. The goal is to identify user/developer scenarios which people are depending on today, and add tests that make it unlikely we would break those users in the future. Every added test should be written from the perspective of what someone using WinForms will try to do, and validate they will get the expected result. The difference is subtle for public APIs, but for internal APIs that aren't always obvious to invoke, it becomes important to try and write tests targeting those features against public APIs where possible. Tests that exercise behavior using public APIs better reflect user behavior and the tests are much easier to understand if a failure ever shows up. |
This issue is now marked as "help wanted", and we’re looking for a community volunteer to work on this issue. If we receive no interest in 180 days, we will close the issue. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
Related #10773 Proposed changes Add unit test file: DesignBindingValueUIHandler.cs for public methods of the DesignBindingValueUIHandler.cs
Related #10773 Proposed changes Add unit test file: DataGridViewColumnTypeEditor.cs for public methods of the DataGridViewColumnTypeEditor.cs
Related #10773 - Add unit test StatusCommandUITests.cs for public method of the StatusCommandUI.
Related #10773 ## Proposed changes - Add unit test file: ControlCommandSetTests.cs for public methods and 2 protected methods of the ControlCommandSet.cs. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13130)
Related dotnet#12883 - After the merging of dotnet#12883, [there was a request](dotnet#12883 (comment)) for some specific serialization test cases of the `ToolStripMenuItemCodeDomSerializer` class. - Adds some specific serialization test cases for the `ToolStripMenuItemCodeDomSerializer` class. - None - Minimal - Unit tests - 10.0.100-preview.3.25167.3
…mCodeDomSerializer` class Related dotnet#10773 Related dotnet#12883 - After the merging of dotnet#12883, [there was a request](dotnet#12883 (comment)) for some specific serialization test cases of the `ToolStripMenuItemCodeDomSerializer` class. - Adds some specific serialization test cases for the `ToolStripMenuItemCodeDomSerializer` class. - None - Minimal - Unit tests - 10.0.100-preview.3.25167.3
…mCodeDomSerializer` class Related dotnet#10773 Related dotnet#12883 - After the merging of dotnet#12883, [there was a request](dotnet#12883 (comment)) for some specific serialization test cases of the `ToolStripMenuItemCodeDomSerializer` class. - Adds some specific serialization test cases for the `ToolStripMenuItemCodeDomSerializer` class. - None - Minimal - Unit tests - 10.0.100-preview.3.25167.3
Related #10773 ## Proposed changes Add unit test DataSourceListEditorTests.cs for public method of the DataSourceListEditor.
* Add code coverage for TabOrder Related #10773
Related #10773 * Add unit tests for ToolStripAdornerWindowService Co-authored-by: Leaf Shi <[email protected]> Co-authored-by: Leaf Shi (BEYONDSOFT CONSULTING INC) <[email protected]>
…mCodeDomSerializer` class (#13200) * Adds some specific serialization test cases for the `ToolStripMenuItemCodeDomSerializer` class Related #10773 Related #12883 - After the merging of #12883, [there was a request](#12883 (comment)) for some specific serialization test cases of the `ToolStripMenuItemCodeDomSerializer` class. - Adds some specific serialization test cases for the `ToolStripMenuItemCodeDomSerializer` class. --------- Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <[email protected]>
Related #10773 Proposed changes Add unit test file: StandardCommandToolStripMenuItemTests.cs for public methods of the StandardCommandToolStripMenuItem.cs
Related #10773 Proposed changes Add unit test ParentControlDesignerTests.cs for public properties and method of the ParentControlDesigner.
* Add unit tests for EditorServiceContext Related #10773 --------- Co-authored-by: Tanya Solyanik <[email protected]>
We are in the process of adding unit tests for all public methods to improve the test coverage of code. Here is a list categorized by namespace.
System.Windows.Forms.Design
FormatControl.CurrencyFormatType.cs(private class)FormatControl.CustomFormatType.cs(private class)FormatControl.DateTimeFormatType.cs(private class)FormatControl.NoFormattingFormatType.cs(private class)FormatControl.NumericFormatType.cs(private class)FormatControl.ScientificFormatType.cs(private class)StatusBarDesignerStatusBar control is deprecatedToolStripMenuItemCodeDomSerializer
class #13200Add unit test for ToolStripInSituService #13021Issue 10773 add coverage for ToolStripInSituService #13297WebBrowserDesignerThis designer has not been ported, tracking it with Support AxDesigner, AxHostDesigner and WebBrowserDesigner capabilities at runtime #9810The text was updated successfully, but these errors were encountered: