Skip to content

Add code coverage for TabOrder #13181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Mar 24, 2025

Related #10773

Proposed changes

Add unit test file: TabOrderTests.cs for public methods & Properties of the TabOrder.cs

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 94.55782% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.66836%. Comparing base (5aa291a) to head (85d0f00).
Report is 53 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13181         +/-   ##
===================================================
+ Coverage   61.35387%   61.66836%   +0.31448%     
===================================================
  Files           1547        1550          +3     
  Lines         158479      158767        +288     
  Branches       14751       14784         +33     
===================================================
+ Hits           97233       97909        +676     
+ Misses         60543       60150        -393     
- Partials         703         708          +5     
Flag Coverage Δ
Debug 61.66836% <94.55782%> (+0.31448%) ⬆️
integration 10.73199% <ø> (+0.00746%) ⬆️
production 39.64821% <ø> (+0.42427%) ⬆️
test 95.67322% <94.55782%> (-0.00625%) ⬇️
unit 37.08815% <ø> (+0.42864%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 24, 2025
@ricardobossan ricardobossan requested a review from Copilot March 26, 2025 20:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds unit tests for the TabOrder class to enhance code coverage for its public methods and properties.

  • New test file TabOrderTests.cs covering constructor behavior, mouse event handlers, command invocation, and command status.

ricardobossan
ricardobossan previously approved these changes Mar 26, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 31, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Apr 1, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 6cb7a47 into dotnet:main Apr 3, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 3, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Apr 3, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_TabOrder branch April 9, 2025 01:03
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants