Skip to content

Add code coverage for FlowLayoutPanelDesigner.cs file #13257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

Add code coverage for FlowLayoutPanelDesigner.cs file #13257

merged 4 commits into from
Apr 16, 2025
+208 −0

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Apr 7, 2025 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test file: FlowLayoutPanelDesignerTests.cs for public method and 6 protected methods of the FlowLayoutPanelDesigner.cs.
Microsoft Reviewers: Open in CodeFlow

@Olina-Zhang Olina-Zhang requested a review from a team as a code owner April 7, 2025 08:54
@codecov Codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.29410%. Comparing base (851d52d) to head (b5485f8).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##                main      #13257          +/-   ##
====================================================
+ Coverage   39.78342%   62.29410%   +22.51068%     
====================================================
  Files           1018        1557         +539     
  Lines          96407      159479       +63072     
  Branches       13451       14868        +1417     
====================================================
+ Hits           38354       99346       +60992     
- Misses         57654       59370        +1716     
- Partials         399         763         +364
Flag Coverage Δ
Debug 62.29410% <100.00000%> (+22.51068%) ⬆️
integration 11.30059% <ø> (+0.57330%) ⬆️
production 40.45372% <ø> (+0.67029%) ⬆️
test 95.67499% <100.00000%> (?)
unit 37.85216% <ø> (+0.62872%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardobossan ricardobossan mentioned this pull request Apr 8, 2025
Open
@ricardobossan ricardobossan requested a review from Copilot April 8, 2025 03:03
Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

ricardobossan
ricardobossan reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several protected override methods appear to be untested. Could you consider adding tests for them?

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Apr 8, 2025
@Olina-Zhang Olina-Zhang removed the waiting-author-feedback The team requires more information from the author label Apr 9, 2025
ricardobossan
ricardobossan previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Apr 10, 2025
Tanya-Solyanik
Tanya-Solyanik reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, looks good otherwise!

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Apr 10, 2025
@Olina-Zhang Olina-Zhang removed the waiting-author-feedback The team requires more information from the author label Apr 14, 2025
ricardobossan
ricardobossan approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Tanya-Solyanik
Tanya-Solyanik approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 5b08b5e into dotnet:main Apr 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@ricardobossan ricardobossan ricardobossan approved these changes

Assignees

@Olina-Zhang Olina-Zhang

Labels
area: test coverage
Projects
None yet
Milestone
10.0 Preview4
Development

Successfully merging this pull request may close these issues.
3 participants
@Olina-Zhang @Tanya-Solyanik @ricardobossan