-
Notifications
You must be signed in to change notification settings - Fork 0
Build custom FC for direct memory access #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Filename mismatch: workflow expects vmlinux.bin but gets firecracker
The build.sh script copies the built binary as firecracker to the builds directory, but the "Prepare release assets" step in the workflow attempts to copy vmlinux.bin from each build directory. This filename mismatch will cause the release preparation to fail when running on the main branch, as the expected file does not exist.
.github/workflows/fc-versions.yml#L99-L100
fc-versions/.github/workflows/fc-versions.yml
Lines 99 to 100 in d3dc8af
| name=$(basename "$dir") | |
| cp "$dir/vmlinux.bin" "release-assets/${name}.bin" |
build.sh#L49-L50
Lines 49 to 50 in d3dc8af
| mkdir -p "../builds/${version_name}" | |
| cp build/cargo_target/x86_64-unknown-linux-musl/release/firecracker "../builds/${version_name}/firecracker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Build outputs firecracker but workflow expects vmlinux.bin
The build.sh script copies the built binary as firecracker into the builds directory, but the "Prepare release assets" step in the workflow attempts to copy vmlinux.bin which doesn't exist. This mismatch will cause the release process to fail on main branch when trying to create release assets because $dir/vmlinux.bin will not be found.
.github/workflows/fc-versions.yml#L99-L100
fc-versions/.github/workflows/fc-versions.yml
Lines 99 to 100 in 7adc7fb
| name=$(basename "$dir") | |
| cp "$dir/vmlinux.bin" "release-assets/${name}.bin" |
build.sh#L50-L51
Lines 50 to 51 in 7adc7fb
| mkdir -p "../builds/${version_name}" | |
| cp build/cargo_target/x86_64-unknown-linux-musl/release/firecracker "../builds/${version_name}/firecracker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Release step references non-existent file vmlinux.bin
The "Prepare release assets" step tries to copy vmlinux.bin from each build directory, but build.sh now produces a file named firecracker instead. The build outputs ../builds/${version_name}/firecracker while the workflow expects $dir/vmlinux.bin. This mismatch will cause the release preparation to fail on the main branch when trying to copy files that don't exist.
.github/workflows/fc-versions.yml#L99-L100
fc-versions/.github/workflows/fc-versions.yml
Lines 99 to 100 in 9dcfada
| name=$(basename "$dir") | |
| cp "$dir/vmlinux.bin" "release-assets/${name}.bin" |
build.sh#L50-L51
Lines 50 to 51 in 9dcfada
| mkdir -p "../builds/${version_name}" | |
| cp build/cargo_target/x86_64-unknown-linux-musl/release/firecracker "../builds/${version_name}/firecracker" |
Note
Builds Firecracker from a custom repository across specified versions and publishes per-version artifacts/tags/releases, with uploads to GCS on main.
.github/workflows/build.yml): parsesfirecracker_versions.txt, runs matrix builds, uploads artifacts per version..github/workflows/fc-versions.yml): adds concurrency; invokes reusable build; downloads merged artifacts; uploads to GCS onmain; creates git tags and GitHub releases per built version, attaching the binary.build.sh):e2b-dev/firecrackerand supportstag_shorthashversion format with ancestry validation.firecrackerbinary (release) and outputs tobuilds/<version>/firecracker.firecracker_versions.txt.README.md): rename tofc-versions; update build instructions and artifact paths.firecracker_versions.txtwith additional versions, includingtag_shorthashentries.Written by Cursor Bugbot for commit dba0c82. This will update automatically on new commits. Configure here.