-
Notifications
You must be signed in to change notification settings - Fork 0
Build custom FC for direct memory access #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ValentaTomas
wants to merge
17
commits into
refactor
Choose a base branch
from
fc-mem-patch
base: refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5ab5207
Switch to custom fc repo; Add build versions
ValentaTomas 94b51ac
Fix parsing; parallelize
ValentaTomas d3dc8af
Refactor
ValentaTomas 7adc7fb
Build only fc
ValentaTomas 9dcfada
Remove ineffective cache
ValentaTomas 836104c
Refactor
ValentaTomas 37e7f2b
Cleanup
ValentaTomas ab24b34
Fail fast on build
ValentaTomas 14f2286
Cancel progress on branches on new push
ValentaTomas c1ad4c8
Test cancel
ValentaTomas dba0c82
Cleanup
ValentaTomas 5cbdae9
Merge branch 'refactor' into fc-mem-patch
ValentaTomas 90ee4f5
Merge branch 'refactor' into fc-mem-patch
ValentaTomas 6b5b0c2
Merge
ValentaTomas 4291380
Update version
ValentaTomas e78abaa
Merge branch 'fc-mem-patch' of https://github.com/e2b-dev/fc-versions…
ValentaTomas 5809d70
Merge branch 'refactor' into fc-mem-patch
ValentaTomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: Build Firecracker Versions | ||
|
|
||
| on: | ||
| workflow_call: | ||
| outputs: | ||
| versions: | ||
| description: "JSON array of versions that were built" | ||
| value: ${{ jobs.prepare.outputs.versions }} | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| prepare: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| versions: ${{ steps.set-versions.outputs.versions }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Parse versions from file | ||
| id: set-versions | ||
| run: | | ||
| # Read versions, skip comments and empty lines, output as JSON array | ||
| versions=$(grep -v '^ *#' firecracker_versions.txt | grep -v '^$' | jq -R -s -c 'split("\n") | map(select(length > 0))') | ||
| echo "versions=$versions" >> $GITHUB_OUTPUT | ||
| echo "Building versions: $versions" | ||
|
|
||
| build: | ||
| needs: prepare | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: ${{ fromJson(needs.prepare.outputs.versions) }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # Set up Docker Buildx for better caching | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| # Cache Docker layers | ||
| - name: Cache Docker layers | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: /tmp/.buildx-cache | ||
| key: docker-buildx-${{ runner.os }}-${{ matrix.version }}-${{ github.sha }} | ||
| restore-keys: | | ||
| docker-buildx-${{ runner.os }}-${{ matrix.version }}- | ||
| docker-buildx-${{ runner.os }}- | ||
|
|
||
| # Cache Cargo registry and git dependencies | ||
| - name: Cache Cargo | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cargo/registry | ||
| ~/.cargo/git | ||
| key: cargo-${{ runner.os }}-${{ matrix.version }}-${{ github.sha }} | ||
| restore-keys: | | ||
| cargo-${{ runner.os }}-${{ matrix.version }}- | ||
| cargo-${{ runner.os }}- | ||
|
|
||
| - name: Build Firecracker ${{ matrix.version }} | ||
| run: ./build.sh "${{ matrix.version }}" | ||
|
|
||
| - name: Upload build artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: firecracker-${{ matrix.version }} | ||
| path: builds/ | ||
| retention-days: 30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| v1.10.1 | ||
| v1.12.1 | ||
| v1.12.1 | ||
| v1.10.1_99e280c5 | ||
| v1.12.1_0bb99c51 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.