Skip to content

fix(api): correct error log message in RemoveSandbox#2449

Merged
jakubno merged 2 commits intomainfrom
fix/api-remove-sandbox-log-message
Apr 19, 2026
Merged

fix(api): correct error log message in RemoveSandbox#2449
jakubno merged 2 commits intomainfrom
fix/api-remove-sandbox-log-message

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Apr 19, 2026

The log said "Error pausing sandbox" in the generic removeSandboxFromNode failure path, which covers pause, kill, and snapshot. Make it accurate.

The log said "Error pausing sandbox" in the generic removeSandboxFromNode
failure path, which covers pause, kill, and snapshot. Make it accurate.
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 19, 2026

PR Summary

Low Risk
Low risk change limited to logging text/fields in the sandbox removal failure path; no behavior, data flow, or security logic is modified.

Overview
Updates RemoveSandbox to log Error removing sandbox (instead of Error pausing sandbox) when removeSandboxFromNode fails, and includes the state_action field to better identify which removal transition (pause/kill/etc.) triggered the error.

Reviewed by Cursor Bugbot for commit 0776f8f. Bugbot is set up for automated code reviews on this repo. Configure here.

@jakubno jakubno marked this pull request as ready for review April 19, 2026 15:46
Makes it possible to distinguish pause/kill/snapshot failures without
cross-referencing the caller.
@jakubno jakubno enabled auto-merge (squash) April 19, 2026 15:47
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — single log string fix, no behavior change.

Extended reasoning...

Overview

Single-line change in packages/api/internal/orchestrator/delete_instance.go: corrects the error log message in the RemoveSandbox generic failure path from "Error pausing sandbox" to "Error removing sandbox". This path is reached after removeSandboxFromNode returns an error, which can be triggered by pause, kill, or snapshot actions — so the old message was misleading.

Security risks

None. No logic, auth, data handling, or external interface is modified.

Level of scrutiny

Minimal scrutiny required. This is a one-line log string correction with zero behavioral impact.

Other factors

No bugs reported. No open reviewer comments. Change is mechanical and obviously correct.

@jakubno jakubno merged commit acda873 into main Apr 19, 2026
44 checks passed
@jakubno jakubno deleted the fix/api-remove-sandbox-log-message branch April 19, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants