-
Notifications
You must be signed in to change notification settings - Fork 15
include external needs into needs.json #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the inclusion of external needs into the needs.json file by uncommenting and setting the needs_builder_filter
configuration option in the Sphinx documentation configuration.
- Uncomments and activates the
needs_builder_filter
configuration option - Sets the filter to an empty string to include all external needs
@@ -64,4 +64,6 @@ | |||
|
|||
# Enable numref | |||
numfig = True | |||
# needs_builder_filter = "" | |||
|
|||
# Include all external needs into needs.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 68 states this will 'Include all external needs into needs.json', but setting needs_builder_filter to an empty string may not achieve this purpose. Consider adding documentation or a more descriptive comment explaining what an empty filter accomplishes versus other filter values.
# Include all external needs into needs.json | |
# Include all external needs into needs.json by setting needs_builder_filter to an empty string. | |
# An empty string ensures that no filtering is applied, and all external needs are included. |
Copilot uses AI. Check for mistakes.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-check Status: ✅ Passed Click to expand output
|
The created documentation from the pull request is available at: docu-html |
I wonder if we should put this into docs as code inside the extensions. Maybe metamodel. |
/consumer-test |
not sure we still want that |
@@ -64,4 +64,6 @@ | |||
|
|||
# Enable numref | |||
numfig = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another test
No description provided.