Skip to content

include external needs into needs.json #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

include external needs into needs.json #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,6 @@

# Enable numref
numfig = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another test

# needs_builder_filter = ""

# Include all external needs into needs.json
Copy link
Preview

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 68 states this will 'Include all external needs into needs.json', but setting needs_builder_filter to an empty string may not achieve this purpose. Consider adding documentation or a more descriptive comment explaining what an empty filter accomplishes versus other filter values.

Suggested change
# Include all external needs into needs.json
# Include all external needs into needs.json by setting needs_builder_filter to an empty string.
# An empty string ensures that no filtering is applied, and all external needs are included.

Copilot uses AI. Check for mistakes.

needs_builder_filter = ""