fix: netcdf date/time metadata type should be int#555
Open
aaron-hopkinson wants to merge 3 commits intomainfrom
Open
fix: netcdf date/time metadata type should be int#555aaron-hopkinson wants to merge 3 commits intomainfrom
aaron-hopkinson wants to merge 3 commits intomainfrom
Conversation
floriankrb
approved these changes
Mar 9, 2026
github-project-automation
bot
moved this from To be triaged
to For merging
in Anemoi-dev
Member
|
@tnipen raising awareness. We don't expect any issues for MEPS data as there is some test coverage. |
MeraX
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The date/time metadata values coming from netCDF datasets were previously strings which differs from grib data and prevents grouping together in a matching filter – this change converts them to integers (which aligns with the behaviour in earthkit-data) and adds a regression test to prevent our xarray support code from diverging from earthkit-data in this area.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.