Skip to content

fix: netcdf date/time metadata type should be int #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-hopkinson wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: netcdf date/time metadata type should be int #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b1dd70
Add failing test to confirm date/time netcdf metadata has wrong type
aaron-hopkinson Feb 26, 2026
e7bd7e3
fix: netcdf date/time metadata - failing test passes
aaron-hopkinson Feb 26, 2026
2e9f1f6
Merge branch 'main' into fix/netcdf_time_metadata_type
floriankrb Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/anemoi/datasets/create/sources/xarray_support/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ def fill_time_metadata(self, coords_values: dict[str, Any], metadata: dict[str,
"""
valid_datetime = coords_values[self.time_coordinate_name]

metadata["date"] = as_datetime(valid_datetime).strftime("%Y%m%d")
metadata["time"] = as_datetime(valid_datetime).strftime("%H%M")
metadata["date"] = int(as_datetime(valid_datetime).strftime("%Y%m%d"))
metadata["time"] = int(as_datetime(valid_datetime).strftime("%H%M"))
metadata["step"] = 0

return valid_datetime
Expand Down Expand Up @@ -235,8 +235,8 @@ def fill_time_metadata(self, coords_values: dict[str, Any], metadata: dict[str,
hours = step.total_seconds() / 3600
assert int(hours) == hours

metadata["date"] = as_datetime(base_datetime).strftime("%Y%m%d")
metadata["time"] = as_datetime(base_datetime).strftime("%H%M")
metadata["date"] = int(as_datetime(base_datetime).strftime("%Y%m%d"))
metadata["time"] = int(as_datetime(base_datetime).strftime("%H%M"))
metadata["step"] = int(hours)

# When date is present, it should be compatible with time and step
Expand Down Expand Up @@ -305,8 +305,8 @@ def fill_time_metadata(self, coords_values: dict[str, Any], metadata: dict[str,
hours = step.total_seconds() / 3600
assert int(hours) == hours

metadata["date"] = as_datetime(base_datetime).strftime("%Y%m%d")
metadata["time"] = as_datetime(base_datetime).strftime("%H%M")
metadata["date"] = int(as_datetime(base_datetime).strftime("%Y%m%d"))
metadata["time"] = int(as_datetime(base_datetime).strftime("%H%M"))
metadata["step"] = int(hours)

return valid_datetime
Expand Down Expand Up @@ -362,8 +362,8 @@ def fill_time_metadata(self, coords_values: dict[str, Any], metadata: dict[str,
step = coords_values[self.step_coordinate_name]
assert isinstance(step, datetime.timedelta)

metadata["date"] = as_datetime(date).strftime("%Y%m%d")
metadata["time"] = as_datetime(date).strftime("%H%M")
metadata["date"] = int(as_datetime(date).strftime("%Y%m%d"))
metadata["time"] = int(as_datetime(date).strftime("%H%M"))

hours = step.total_seconds() / 3600

Expand Down
16 changes: 16 additions & 0 deletions tests/xarray/test_netcdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import os

import earthkit.data as ekd
import xarray as xr
from multiurl import download

Expand Down Expand Up @@ -45,6 +46,21 @@
}


def test_netcdf_metadata_types_compare_with_ekd():
ekd_fl = ekd.from_source("sample", "era5-hourly-2t-20230724T1200Z.nc")
ds = ekd_fl.to_xarray()

ads_fl = XarrayFieldList.from_xarray(ds)
assert len(ekd_fl) == len(ads_fl)

common_keys = set(ekd_fl[0].metadata().keys()) & set(ads_fl[0].metadata().keys())
assert {"date", "time", "variable"}.issubset(common_keys)

# check that metadata value types are the same whether going via earthkit-data or anemoi-datasets
for key in common_keys:
assert type(ekd_fl[0].metadata(key)) is type(ads_fl[0].metadata(key)), f"Type mismatch for key '{key}'"


def skip_test_netcdf() -> None:
"""Test loading and validating various NetCDF datasets."""
for url, checks in URLS.items():
Expand Down
Loading