fix: Sphinx 8 deploy flags and re-enable automatic releases - #227
Conversation
The deploy-production job in push.yml has its own inline sphinx-build that was not updated alongside build-docs-optimized.yml in PR #225. Sphinx 8 strictly validates -D boolean flags and rejects 'false', requiring '0' instead. Also removed 2>/dev/null that was hiding all build errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughUpdated two Sphinx build directives in the production build step of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 PR Documentation DeployedYour PR documentation is available with enhanced build performance: 🔗 PR Documentation: https://edbook.github.io/haskoli-islands/fix/push-deploy-sphinx8-flags/ ✨ Performance Features:
Version: |
The release workflow's push trigger was removed at 282c701 because historical runs failed. The root cause was a Sphinx build failure, not the trigger itself. Changes: - Re-add push trigger for main branch with path filters (projects/, cli/) - Remove workflow_dispatch-only guard on create-release job - Add concurrency group to prevent concurrent release attempts - Exclude .github/** from paths to avoid releases on CI-only changes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
push.ymlrelease.ymlChanges
push.yml — Deploy build fix
-D html_show_sourcelink=falseto=0and-D html_copy_source=falseto=0(Sphinx 8 requires0/1, notfalse/true)2>/dev/nullthat was silently hiding build errorsrelease.yml — Automatic releases
pushtrigger for main branch (removed at 282c701 when Sphinx builds were failing)if: github.event_name == 'workflow_dispatch'guard oncreate-releasejob that prevented releases on push eventsprojects/**andcli/**(excludes.github/**so CI-only changes don't create releases)Context
The deploy failure on main was caused by the inline
sphinx-buildstep inpush.yml'sdeploy-productionjob — separate from the reusablebuild-docs-optimized.ymlwhich was already fixed in PR #225.The release workflow had its push trigger removed because historical runs failed during the build phase. Now that Sphinx 8 builds are working correctly, the trigger is safe to restore.
Test plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Summary by CodeRabbit