Skip to content

Replace deprecated JSON.fast_generate with JSON.generate #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pascaltozzi
Copy link

@pascaltozzi pascaltozzi commented May 8, 2025

What does this pull request do?

This is a non-functional refactor with no behavioral changes.

As of version 2.11.0 of the json gem, JSON.fast_generate has been deprecated because it provides no measurable performance benefit over JSON.generate.

Why is it important?

It remove deprecation warnings and maintain forward compatibility.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.asciidoc
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
729d503

Please, read and sign the above mentioned agreement if you want to contribute to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant