Skip to content

Replace deprecated JSON.fast_generate with JSON.generate #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace deprecated JSON.fast_generate with JSON.generate #1552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elastic_apm/transport/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class Connection

def initialize(config)
@config = config
@metadata = JSON.fast_generate(
@metadata = JSON.generate(
Serializers::MetadataSerializer.new(config).build(
Metadata.new(config)
)
Expand Down
2 changes: 1 addition & 1 deletion lib/elastic_apm/transport/worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def serialize_and_filter(resource)
# if a filter returns nil, it means skip the event
return nil if @filters.apply!(serialized) == Filters::SKIP

JSON.fast_generate(serialized)
JSON.generate(serialized)
rescue Exception
error format('Failed converting event to JSON: %s', resource.inspect)
error serialized.inspect
Expand Down
2 changes: 1 addition & 1 deletion spec/elastic_apm/transport/connection/http_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module Transport
let(:config) { Config.new(http_compression: false) }

let(:metadata) do
JSON.fast_generate(metadata: { service_name: 'Test' })
JSON.generate(metadata: { service_name: 'Test' })
end

let(:url) { 'http://localhost:8200/intake/v2/events' }
Expand Down
2 changes: 1 addition & 1 deletion spec/elastic_apm/transport/connection_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ module Transport

before do
config.api_request_size =
"#{JSON.fast_generate(metadata).bytesize - 1}b"
"#{JSON.generate(metadata).bytesize - 1}b"
end

it 'closes requests when reached' do
Expand Down
Loading