Fix and improvements for PHPStan (rule level 5) #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, very excited for this to be released so we can start using it :) Looks like after this as been merged getting to PHPStan lvl 6 will also be doable which would mean that all interfaces are documented. |
miguelgrinberg
approved these changes
Mar 27, 2025
|
What's the process for this ending up in a release? I see it's merged into a version branch and not the latest? |
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1439. It includes all the feedback from @AJenbo given in #1439. Thanks @AJenbo!
It fixes the PHPStan issues reported in #1425, #1424, #1423 and #1346. It also improved the PHPStan rule level to 5 🎉