Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improvements for PHPStan (rule level 5) #1442

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Fix and improvements for PHPStan (rule level 5) #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4139cc6
Fixes for PHPStan issues
ezimuel Mar 24, 2025
a555e39
Added support for array<string> in path parts
ezimuel Mar 25, 2025
3794938
Reintroduced the body with null coalescing operator
ezimuel Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
parameters:
level: 2
level: 5
paths:
- src
ignoreErrors:
- '#PHPDoc tag @param has invalid value#'
- '#Offset ''body'' on array\{\}\|array\{#'
153 changes: 79 additions & 74 deletions src/Endpoints/AsyncSearch.php
View file
Open in desktop

Large diffs are not rendered by default.

66 changes: 35 additions & 31 deletions src/Endpoints/Autoscaling.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ class Autoscaling extends AbstractEndpoint
*
* @param array{
* name: string, // (REQUIRED) the name of the autoscaling policy
* master_timeout: time, // Timeout for processing on master node
* timeout: time, // Timeout for acknowledgement of update from all nodes in cluster
* pretty: boolean, // Pretty format the returned JSON response. (DEFAULT: false)
* human: boolean, // Return human readable values for statistics. (DEFAULT: true)
* error_trace: boolean, // Include the stack trace of returned errors. (DEFAULT: false)
* source: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path: list, // A comma-separated list of filters used to reduce the response.
* master_timeout?: int|string, // Timeout for processing on master node
* timeout?: int|string, // Timeout for acknowledgement of update from all nodes in cluster
* pretty?: bool, // Pretty format the returned JSON response. (DEFAULT: false)
* human?: bool, // Return human readable values for statistics. (DEFAULT: true)
* error_trace?: bool, // Include the stack trace of returned errors. (DEFAULT: false)
* source?: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path?: string|array<string>, // A comma-separated list of filters used to reduce the response.
* } $params
*
* @throws MissingParameterException if a required parameter is missing
Expand All @@ -51,8 +51,9 @@ class Autoscaling extends AbstractEndpoint
*
* @return Elasticsearch|Promise
*/
public function deleteAutoscalingPolicy(array $params = [])
public function deleteAutoscalingPolicy(?array $params = null)
{
$params = $params ?? [];
$this->checkRequiredParameters(['name'], $params);
$url = '/_autoscaling/policy/' . $this->encode($params['name']);
$method = 'DELETE';
Expand All @@ -73,12 +74,12 @@ public function deleteAutoscalingPolicy(array $params = [])
* @see https://www.elastic.co/guide/en/elasticsearch/reference/current/autoscaling-get-autoscaling-capacity.html
*
* @param array{
* master_timeout: time, // Timeout for processing on master node
* pretty: boolean, // Pretty format the returned JSON response. (DEFAULT: false)
* human: boolean, // Return human readable values for statistics. (DEFAULT: true)
* error_trace: boolean, // Include the stack trace of returned errors. (DEFAULT: false)
* source: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path: list, // A comma-separated list of filters used to reduce the response.
* master_timeout?: int|string, // Timeout for processing on master node
* pretty?: bool, // Pretty format the returned JSON response. (DEFAULT: false)
* human?: bool, // Return human readable values for statistics. (DEFAULT: true)
* error_trace?: bool, // Include the stack trace of returned errors. (DEFAULT: false)
* source?: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path?: string|array<string>, // A comma-separated list of filters used to reduce the response.
* } $params
*
* @throws NoNodeAvailableException if all the hosts are offline
Expand All @@ -87,8 +88,9 @@ public function deleteAutoscalingPolicy(array $params = [])
*
* @return Elasticsearch|Promise
*/
public function getAutoscalingCapacity(array $params = [])
public function getAutoscalingCapacity(?array $params = null)
{
$params = $params ?? [];
$url = '/_autoscaling/capacity';
$method = 'GET';

Expand All @@ -109,12 +111,12 @@ public function getAutoscalingCapacity(array $params = [])
*
* @param array{
* name: string, // (REQUIRED) the name of the autoscaling policy
* master_timeout: time, // Timeout for processing on master node
* pretty: boolean, // Pretty format the returned JSON response. (DEFAULT: false)
* human: boolean, // Return human readable values for statistics. (DEFAULT: true)
* error_trace: boolean, // Include the stack trace of returned errors. (DEFAULT: false)
* source: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path: list, // A comma-separated list of filters used to reduce the response.
* master_timeout?: int|string, // Timeout for processing on master node
* pretty?: bool, // Pretty format the returned JSON response. (DEFAULT: false)
* human?: bool, // Return human readable values for statistics. (DEFAULT: true)
* error_trace?: bool, // Include the stack trace of returned errors. (DEFAULT: false)
* source?: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path?: string|array<string>, // A comma-separated list of filters used to reduce the response.
* } $params
*
* @throws MissingParameterException if a required parameter is missing
Expand All @@ -124,8 +126,9 @@ public function getAutoscalingCapacity(array $params = [])
*
* @return Elasticsearch|Promise
*/
public function getAutoscalingPolicy(array $params = [])
public function getAutoscalingPolicy(?array $params = null)
{
$params = $params ?? [];
$this->checkRequiredParameters(['name'], $params);
$url = '/_autoscaling/policy/' . $this->encode($params['name']);
$method = 'GET';
Expand All @@ -147,14 +150,14 @@ public function getAutoscalingPolicy(array $params = [])
*
* @param array{
* name: string, // (REQUIRED) the name of the autoscaling policy
* master_timeout: time, // Timeout for processing on master node
* timeout: time, // Timeout for acknowledgement of update from all nodes in cluster
* pretty: boolean, // Pretty format the returned JSON response. (DEFAULT: false)
* human: boolean, // Return human readable values for statistics. (DEFAULT: true)
* error_trace: boolean, // Include the stack trace of returned errors. (DEFAULT: false)
* source: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path: list, // A comma-separated list of filters used to reduce the response.
* body: array, // (REQUIRED) the specification of the autoscaling policy
* master_timeout?: int|string, // Timeout for processing on master node
* timeout?: int|string, // Timeout for acknowledgement of update from all nodes in cluster
* pretty?: bool, // Pretty format the returned JSON response. (DEFAULT: false)
* human?: bool, // Return human readable values for statistics. (DEFAULT: true)
* error_trace?: bool, // Include the stack trace of returned errors. (DEFAULT: false)
* source?: string, // The URL-encoded request definition. Useful for libraries that do not accept a request body for non-POST requests.
* filter_path?: string|array<string>, // A comma-separated list of filters used to reduce the response.
* body: string|array<mixed>, // (REQUIRED) the specification of the autoscaling policy. If body is a string must be a valid JSON.
* } $params
*
* @throws MissingParameterException if a required parameter is missing
Expand All @@ -164,8 +167,9 @@ public function getAutoscalingPolicy(array $params = [])
*
* @return Elasticsearch|Promise
*/
public function putAutoscalingPolicy(array $params = [])
public function putAutoscalingPolicy(?array $params = null)
{
$params = $params ?? [];
$this->checkRequiredParameters(['name','body'], $params);
$url = '/_autoscaling/policy/' . $this->encode($params['name']);
$method = 'PUT';
Expand Down
Loading