Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to embedded-hal 1.0. #16

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

reitermarkus
Copy link
Contributor

No description provided.

@reitermarkus reitermarkus force-pushed the embedded-hal-1 branch 6 times, most recently from 3cd5be3 to fa3ca00 Compare January 13, 2024 22:08
@reitermarkus reitermarkus changed the title WIP: Update to embedded-hal 1.0. Update to embedded-hal 1.0. Jan 13, 2024
@reitermarkus reitermarkus force-pushed the embedded-hal-1 branch 6 times, most recently from 95b813a to 1d22965 Compare January 14, 2024 05:31
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work.
However, this is way too big for me to review as-is.
Could you split this into smaller PRs?

@reitermarkus
Copy link
Contributor Author

reitermarkus commented Jan 17, 2024

@eldruin, I moved the additional changes to a separate PR. This one should be manageable now.

Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still changes many things on top of updating to e-h 1.0.

  • Please do not remove DynamicOneShot. It is a useful trait asked for by the community.
  • Why did you remove the whole device-specific channel selection mechanism? That ensures that only valid channels for the current device can be read.

@reitermarkus
Copy link
Contributor Author

Please do not remove DynamicOneShot. It is a useful trait asked for by the community.

From reading #10 (comment), it looks like this trait didn't actually solve the issue, which is why I removed it.

Why did you remove the whole device-specific channel selection mechanism? That ensures that only valid channels for the current device can be read.

Ah, I missed that this ensures only valid channels. I simply removed it since there is no corresponding embedded-hal 1.0 trait to base this on.

@reitermarkus
Copy link
Contributor Author

@eldruin, I have now re-added the device-specific channel selection.

Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many changes here for a PR only intended to update e-h (as per the title).
Could you only do that and do the rest in separate PRs, please?

.github/workflows/build.yml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@reitermarkus reitermarkus force-pushed the embedded-hal-1 branch 2 times, most recently from 156564d to 389d5bc Compare January 18, 2024 15:50
This was referenced Jan 18, 2024
@reitermarkus reitermarkus requested a review from eldruin January 18, 2024 16:01
@reitermarkus reitermarkus force-pushed the embedded-hal-1 branch 2 times, most recently from e52dd96 to d809bfc Compare January 18, 2024 18:52
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. Other than the comments this looks good to me now.

src/channel.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
src/devices/mode/oneshot.rs Show resolved Hide resolved
@eldruin eldruin merged commit 451f9fb into eldruin:master Jan 19, 2024
22 of 23 checks passed
@reitermarkus reitermarkus deleted the embedded-hal-1 branch January 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants