Allow the Login screen to use the dark theme #31293
Open
+0
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a whole bunch of code dedicated to attempting to force a "light" theme onto the login view, even if the deployment is configured to prioritise the dark theme. Apparently this was done because, in the old days, the login view looked rubbish with the dark theme, but now it looks fine. Fixes #31292
richvdh
force-pushed
the
rav/kill_isLogin
branch
from
7220894 to
60b900c
Compare
Member
|
This would certainly be nice, probably needs a nod from design to confirm it's okay. |
florianduros
approved these changes
Nov 21, 2025
Member
|
I am unable to test it, the link is taking me to the light mode implementation. Unless it follows system settings? |
Member
Author
Yup, the test deployments don't specify a particular theme in their configuration, which means they will follow the system settings. If you're using Firefox it has a "Website Appearance" setting which you could try setting to "Dark"? |
Member
Author
|
Turns out the "Decentralised, encrypted chat & collaboration powered by [matrix]" text on the welcome page is the wrong colour, so that's a thing to fix: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a whole bunch of code dedicated to attempting to force a "light" theme onto the login view, even if the deployment is configured to prioritise the dark theme.
Apparently this was done because, in the old days, the login view looked rubbish with the dark theme (matrix-org/matrix-react-sdk#4014), but nowadays it looks fine:
Fixes #31292