Fix Compound Link elements not having an underline.#31583
Merged
Conversation
t3chguy
approved these changes
Dec 19, 2025
Half-Shot
commented
Dec 19, 2025
| <Link>. | ||
| */ | ||
| a:not([data-kind]) { | ||
| &:hover, |
Member
Author
There was a problem hiding this comment.
while I'm here, I was struggling to really figure out what this is doing. I hate that we perform blanket CSS changes links across the app, but I think this can only now be fixed by replacing our bare tags with proper components.
Half-Shot
commented
Dec 19, 2025
Member
Author
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Blocked on element-hq/compound-web#415
…ing-compound-links
andybalaam
approved these changes
Jan 5, 2026
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Fine from a crypto point of view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on element-hq/compound-web#418
Specifically this is fixing the "Messages you send will be shared with new members invited to this room" banner not having a proper underline on Learn more.
Checklist
public/exportedsymbols have accurate TSDoc documentation.