Skip to content

Fix Compound Link elements not having an underline. #31583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Half-Shot merged 8 commits into from
Jan 5, 2026
Merged

Fix Compound Link elements not having an underline. #31583

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d51d2e8
Do not alter text-decoration if an <a> tag is a Link.
Half-Shot Dec 19, 2025
f617e5d
Update screenshots
Half-Shot Dec 19, 2025
70ffe04
update compound web to 8.3.4
Half-Shot Jan 2, 2026
74f81c8
Update snaps
Half-Shot Jan 2, 2026
5001d3b
Merge remote-tracking branch 'origin/develop' into hs/prevent-overrid…
Half-Shot Jan 2, 2026
2a632e3
Update alllllll the snaps
Half-Shot Jan 2, 2026
d2f0040
update screenshots
Half-Shot Jan 2, 2026
0c57636
Merge branch 'develop' into hs/prevent-overriding-compound-links
Half-Shot Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...ading/feature-detection.spec.ts/unsupported-browser-CompatibilityView-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...apshots/crypto/history-sharing.spec.ts/shared-history-invite-accepted-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 11 additions & 4 deletions res/themes/light/css/_mods.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@
background-color: transparent !important;
}

a:hover,
a:link,
a:visited {
text-decoration: none;
/*
data-kind is used by the Compound <Link> component and therefore does not override them.
This is horrible, but will get less horrible when links in the app are replaced with
<Link>.
*/
a:not([data-kind]) {
&:hover,
Copy link
Member Author

@Half-Shot Half-Shot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I'm here, I was struggling to really figure out what this is doing. I hate that we perform blanket CSS changes links across the app, but I think this can only now be fixed by replacing our bare tags with proper components.

&:link,
&:visited {
text-decoration: none;
}
}
Loading