Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore public visibility of classes containing swazzled code #1820

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Restore public visibility of classes containing swazzled code #1820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...id-core/src/main/java/io/embrace/android/embracesdk/WebViewChromeClientSwazzledHooks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @hide
*/
@InternalApi
final class WebViewChromeClientSwazzledHooks {
public final class WebViewChromeClientSwazzledHooks {

private WebViewChromeClientSwazzledHooks() {
}
Expand Down
15 changes: 15 additions & 0 deletions embrace-android-sdk/api/embrace-android-sdk.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,18 @@ public final class io/embrace/android/embracesdk/Embrace$Companion {
public final fun getInstance ()Lio/embrace/android/embracesdk/Embrace;
}

public final class io/embrace/android/embracesdk/ViewSwazzledHooks {
}

public final class io/embrace/android/embracesdk/ViewSwazzledHooks$OnClickListener {
public static fun _preOnClick (Landroid/view/View$OnClickListener;Landroid/view/View;)V
}

public final class io/embrace/android/embracesdk/ViewSwazzledHooks$OnLongClickListener {
public static fun _preOnLongClick (Landroid/view/View$OnLongClickListener;Landroid/view/View;)V
}

public final class io/embrace/android/embracesdk/WebViewClientSwazzledHooks {
public static fun _preOnPageStarted (Landroid/webkit/WebView;Ljava/lang/String;Landroid/graphics/Bitmap;)V
}

2 changes: 1 addition & 1 deletion embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/ViewSwazzledHooks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @hide
*/
@InternalApi
final class ViewSwazzledHooks {
public final class ViewSwazzledHooks {

private static final String UNKNOWN_ELEMENT_NAME = "Unknown element";

Expand Down
10 changes: 6 additions & 4 deletions ...e-android-sdk/src/main/java/io/embrace/android/embracesdk/WebViewClientSwazzledHooks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
package io.embrace.android.embracesdk;

import androidx.annotation.Nullable;

import io.embrace.android.embracesdk.annotation.InternalApi;

/**
* @hide
*/
@InternalApi
final class WebViewClientSwazzledHooks {
public final class WebViewClientSwazzledHooks {

private WebViewClientSwazzledHooks() {
}

@SuppressWarnings("MethodNameCheck")
public static void _preOnPageStarted(android.webkit.WebView view,
java.lang.String url,
android.graphics.Bitmap favicon) {
public static void _preOnPageStarted(@Nullable android.webkit.WebView view,
@Nullable java.lang.String url,
@Nullable android.graphics.Bitmap favicon) {
Embrace.getInstance().logWebView(url);
}
}
Loading