Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore public visibility of classes containing swazzled code #1820

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 15, 2025

Goal

Restore public-ness of classes whose methods are injected into the bytecode by the swazzler

Note: lint picked up some nullality annotation issues so I added them. I hope this won't break things?

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil marked this pull request as ready for review January 17, 2025 07:07
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (69faac8) to head (dfea178).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
+ Coverage   85.38%   85.41%   +0.03%     
==========================================
  Files         473      473              
  Lines       11015    11015              
  Branches     1648     1648              
==========================================
+ Hits         9405     9409       +4     
  Misses        877      877              
+ Partials      733      729       -4     
Files with missing lines Coverage Δ
...d/embracesdk/WebViewChromeClientSwazzledHooks.java 0.00% <ø> (ø)
.../embrace/android/embracesdk/ViewSwazzledHooks.java 0.00% <ø> (ø)
...android/embracesdk/WebViewClientSwazzledHooks.java 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Jan 17, 2025

Merge activity

  • Jan 17, 12:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 17, 12:37 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit f5d05e1 into main Jan 17, 2025
7 of 8 checks passed
@bidetofevil bidetofevil deleted the hho/swazzled-hooks branch January 17, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants